Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop dependency #2

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Update rubocop dependency #2

merged 1 commit into from
Oct 7, 2020

Conversation

dakotahp
Copy link
Contributor

@dakotahp dakotahp commented Oct 2, 2020

Bump the dependencies to stay up-to-date. Rubocop moves fast so we can minimize falling behind on rule name changes.

@dakotahp
Copy link
Contributor Author

dakotahp commented Oct 2, 2020

Will I have to test whether the rules are still valid (in terms of rubocop name changes) by trying it on orders? I don't know how to validate if the rules have the correct names within this repo.

@JustinAiken
Copy link
Contributor

JustinAiken commented Oct 2, 2020

Will I have to test whether the rules are still valid (in terms of rubocop name changes) by trying it on orders?

Yep, open a branch that points the ut-rubocop-rails gem to git: "https://github.com/usertesting/ut_rubocop_rails", branch: "dp-bump-rubocop"

@dakotahp
Copy link
Contributor Author

dakotahp commented Oct 7, 2020

@JustinAiken I have a branch for illustration showing the orders gem updated to these updated versions and regenerated the todo file. No major issues. We'll have to add the new rails performance rules to the todo after these are merged and orders is updated.

https://github.com/usertesting/orders/compare/rubocop/update-gem?expand=1

@dakotahp dakotahp merged commit b1abfcc into main Oct 7, 2020
@dakotahp dakotahp deleted the dp-bump-rubocop branch October 7, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants