Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Shortcut #113

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Conversation

steaks
Copy link
Contributor

@steaks steaks commented Sep 10, 2021

#112

Migrates:

Does not migrate:

  • NPM package (still clubhouse-lib)
  • Github repository name (still clubhouse-lib)
  • References to clubhouse-lib in continuous integration
  • Branding in README (e.g. logo)

^ I didn't migrate tasks on the does not migrate list because I didn't think I had permissions to do so. I think it'd make sense to have a Clubhouse employee complete the migration, but I'd be happy to help however I can. Thanks for building and maintaining this project Shortcut team!

@charpeni
Copy link
Member

Thanks for sending this, amazing! 🙌

You were faster than me on it. I'll be reviewing and merging this on Monday.

Copy link
Member

@charpeni charpeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for sending this. 🙇‍♂️ 🎉

I'll take care of the remaining tasks. I was hoping I could generate a new TypeScript library based on our Swagger schema, so stay tuned for upcoming updates, your pull request definitely saved me time in the meantime.

@charpeni charpeni changed the title Migrate to shortcut Migrate to Shortcut Sep 13, 2021
@charpeni charpeni merged commit fa50c1c into useshortcut:main Sep 13, 2021
@steaks steaks deleted the migrate-to-shortcut branch September 14, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants