implemented a 4-bit ANSI background color cycler for every new instance of a progress bar. Also uses the old gray colors for reference #1983
Conversation
…ce of a progress bar. Also uses the old gray colors for reference
|
This is Solarized in Terminal.app: 
You see how they avoid the color yellow because that is the common background color (lightyellow-ish). Still that color name contrasts well with the foreground color. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1983 +/- ##
=======================================
- Coverage 49% 49% -1%
+ Complexity 6291 6285 -6
=======================================
Files 664 664
Lines 59548 59547 -1
Branches 8637 8638 +1
=======================================
- Hits 29420 29405 -15
- Misses 27913 27927 +14
Partials 2215 2215 ☔ View full report in Codecov by Sentry. |
|
This is "Pro" in Terminal.App: 
|
|
This is Solarized in the VScode Xterm.js view: 
I think they did a better job here for all the 4-bit colors. But the big difference is that the foreground color is set to black, while in Terminal.app it is quite a different color. :::tip |
|
Dark theme in VScode: 
:::tip |
|
I think we have to force the foreground to black... |
|
This is Dark mode in Terminal.app with foreground programmatically set to "Black"; apparantly the theme does not map this to white? 
:::tip |
|
This is Solarized in Terminal.app with foreground set to black: 
Again Grey10 does not force a foreground swap as it does in VScode. |
|
Windows Terminal (the new one, with solarized dark theme): Windows Console (the old one, not themeable): |
|
Solarized Terminal.app with forced white foreground: 
|
|
windows terminal met solarized light: |
|
old windows terminal (no theming) |
|
windows solarized dark |
…ith bright white foreground inside the bar and normal text outside the bar; also dropped all the underline and overline fringes for better consistency acros themes. works well with both dark and white themes now, due to the forced bright white foreground and they middle gray which has best contrast if you need to optimize for both dark and light backgrounds at the same time
|
Archiving this PR for later reference. Was not meant to be merged. |
@DavyLandman @PaulKlint this is not for merging; but for trying out all the different colors in the ANSI 4-bit pallette as possible backgrounds. Notice that the names of the colors are not necessarily what people implement in their terminals.
For example, this is what wikipedia reports on different interpretations already: https://en.wikipedia.org/wiki/ANSI_escape_code#3-bit_and_4-bit:~:text=The%20chart%20below%20shows%20a%20few%20examples%20of%20how%20VGA%20standard%20and%20modern%20terminal%20emulators%20translate%20the%204%2Dbit%20color%20codes%20into%2024%2Dbit%20color%20codes.
Let's collect some screenshots here.