Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer adjustments related to inland waters #579

Merged
merged 3 commits into from
Nov 13, 2020

Conversation

mhines-usgs
Copy link
Contributor

Before making a pull request

First . . .

  • Clean the code the way Vue likes it - run 'npm run lint --fix'
  • Make sure all tests run

Then check for accessibly compliance

  • Run WAVE plugin 508 compliance tool

Then run Browserstack; check that application works on . . .

  • Chrome
  • Safari
  • Edge
  • Firefox
  • Samsung Internet
  • Internet Explorer 11 (not supported, but still needs at least a working user redirect page)

Finally . . .

  • Update the changelog appropriately

Title

usgs-makerspace/makerspace-sandbox#680

Description

  • removed the baselayer water features because we wanted to eliminate inland water bodies that are making it hard to interpret the stream temp colors
  • created a new tile set for only the great lakes and added to a jenkins job that puts the tiles in our s3 maptiles prod bucket (pr to come for wbeep-processing jenkinsfile behind that)
  • re-ordered the layers to get arrangement correct
  • adjusted the oceans and great lakes water color to be the more 'bold' blue color from water storage that people liked in the feedback from review, we can do this now that we aren't showing the inland waters.
  • added a state fill layer to fill the states in after changing background layer to be the water color

After making a pull request

  • If appropriate, put the link to the PR in the ticket
  • Assign someone to review unless the change is trivial

@mhines-usgs
Copy link
Contributor Author

here's what it looks like with these changes:
image

@@ -39,110 +45,11 @@ export default {
{
'id': 'background',
'paint': {
'background-color': 'hsl(47, 26%, 88%)'
'background-color': 'hsl(205, 56%, 73%)'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the neighboring countries/land color to the water color

@@ -159,7 +66,21 @@ export default {
},
'showButtonLayerToggle': true
},
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing the background to be the water color instead (since we drop the water baselayer from openmaptiles) makes the states blue, so have to add this solid fill state layer

@@ -183,8 +104,8 @@ export default {
"line-color": [
"interpolate", ["linear"], ["get", "temp"],
0, "#10305d",
14.08, "#c4c1b6",
25.88, "#730000"
15, "#c4c1b6",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is in prep for the legend edit task, but figured i would tweak it while I'm in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants