Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'sent_to' parameter only contains the 'from' values #362

Closed
redbullpeter opened this issue Nov 26, 2015 · 1 comment · Fixed by #370
Closed

'sent_to' parameter only contains the 'from' values #362

redbullpeter opened this issue Nov 26, 2015 · 1 comment · Fixed by #370
Assignees
@eyedol
Labels
Bug report
Milestone
v3.0.5

Comments

@redbullpeter
Copy link

According to the API details the 'sent_to' should contain "the phone number registered on the SIM card otherwise it's the value set on the app as device ID"

However we're seeing that the 'sent_to' parameter always contains the 'from' values.

SMSsync v3.0.4

Handsets tested:

Samsung GT-I9060I Android// 4.4.4
Xolo Q1010i Android 4.4.2
@siddhartham-ysg
Copy link

@ushahidi:

This issue still persists.
We are running v2.8.3 (Micromax-Q3372/ Android: 5.0) and this seems to be ok once you set the phone number on the SIM.
However, v3.0.4 (Samsung-SMG355H / Android: 4.4.2) still has this problem wherein the sent_to value is being picked up from the from field instead. We weren't able to downgrade the SMSSync app, so couldn't isolate the exact problem area.
Can you confirm this? Please, help us out with this!

eyedol added a commit that referenced this issue Feb 12, 2016
@eyedol
A lot of bug fixes to previous release
d53a0be 
- Remove the use of robolectric for unit testing. Now android ships
  native unit testing support.

- Refactor entities to use getters and setters so they can be mocked.

- Add test for post message.

- Add test for single and multiple messages synchronization.

- Fix #362 - Use the device's phone number for the `sent_to`
  field instead of the `from` number.

- Fix #369 - Set imported messages from the phone's inbox `type`
  to `pending` and `status` to failure. This prevents the app
  from crashing when an attempt is made to fetch messages from the app's
  inbox.

- Swipe to manually sync individual messages in the pending list is
  is broken because there was no method call to cause the sync.
  Made a call to `publishItem(int position)` when a swipe occurs.

- Add test for IP based Integration.

- When Test Ingeration button is hit, the app makes a request using
  configured request method to the server. The test request doesn't
  send the `message` and `from` variables to the server. This sometimes
  causes validation error when the server is strict about those two
  parameters. This sometimes leads to testing of the integration to
  report invalid endpoint has been entered. To fix this, added a
  hardcoded message and from values so those are sent along with the
  secret values. This actually makes the test report that the
  configured integration can actually receive messages from the app.

- Upgrade android gradle plugin
@eyedol eyedol added this to the v3.0.5 milestone Feb 12, 2016
@eyedol eyedol mentioned this issue Feb 12, 2016
Merged
@eyedol eyedol self-assigned this Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyedol eyedol

Labels
Bug report
Projects
None yet
Milestone
v3.0.5
Development

Successfully merging a pull request may close this issue.

A lot of bug fixes to previous release ushahidi/SMSSync
3 participants
@eyedol @redbullpeter @siddhartham-ysg