Skip to content

Commit

Permalink
Webpack does not currently correctly replace url(img) appearing as a …
Browse files Browse the repository at this point in the history
…style in en.json. This is less a bug and more a need of a redesign of the video provider logo layout (#449)
  • Loading branch information
willdoran committed Dec 9, 2016
1 parent 806692e commit c83ca19
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
2 changes: 0 additions & 2 deletions app/common/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -583,9 +583,7 @@
"upload" : "Upload"
},
"video" : {
"input_desc" : "<span>Enter a</span><span id=\"wordmark-youtube\" class=\"wordmark-replace\" style=\"background-image: url(/img/youtube.png);\"><span> Youtube</span></span><span> or </span><span id=\"wordmark-vimeo\" class=\"wordmark-replace\" style=\"background-image: url(/img/vimeo.png);\"><span> Vimeo</span></span><span> video URL</span>",
"enter_a" : "Enter a",
"youtube" : " Youtube",
"or" : " or ",
"vimeo" : " Vimeo",
"video_url" : " video URL"
Expand Down
9 changes: 8 additions & 1 deletion app/main/posts/modify/video.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,14 @@
<form>
<div class="form-field video_embed">
<label>{{label}}</label>
<p translate="post.video.input_desc"></p>
<p>
<span translate="post.video.enter_a">Enter a</span>

<img src="/img/youtube.png" class="wordmark-replace">
<span translate="post.video.or"> or </span>
<img src="/img/vimeo.png" class="wordmark-replace">
<span translate="post.video.video_url"> video URL</span>
</p>
<input type="text" ng-model="videoUrl" ng-change="constructIframe(videoUrl)" placeholder="https://youtu.be/123456">

<div id="{{previewId}}" class="form-field-preview" ng-show="videoUrl">
Expand Down

0 comments on commit c83ca19

Please sign in to comment.