Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack background-image: url() #449

Merged
merged 1 commit into from
Dec 9, 2016
Merged

Conversation

willdoran
Copy link
Contributor

@willdoran willdoran commented Dec 9, 2016

This pull request makes the following changes:

  • Changes layout of video.html to include definition of video provider logo images
  • This images were not served by webpack as they were not picked up because they were within the translation string for the video input desc
  • This is a patch the background images should be moved to the css class and webpack config should be set to use resolve-url on the css/scss

Test these changes by:

  • Add/Edit a Post with a Video field, confirm that Youtube and Vimeo logos appear

Fixes ushahidi/platform# .

Ping @ushahidi/platform

…style in en.json. This is less a bug and more a need of a redesign of the video provider logo layout


This change is Reviewable

…style in en.json. This is less a bug and more a need of a redesign of the video provider logo layout
@willdoran willdoran merged commit c83ca19 into develop Dec 9, 2016
@coveralls
Copy link

coveralls commented Dec 9, 2016

Coverage Status

Coverage remained the same at 75.176% when pulling adb870b on hotfix/logo-img-webpack into 806692e on develop.

@ushbot ushbot temporarily deployed to rackspace_pr December 9, 2016 23:15 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants