Fix: response_private fields were not being respected

ushahidi · Jul 21, 2020 · 7fe225e · 7fe225e
1 parent c502a3c
commit 7fe225e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/v5/Http/Middleware/V5GlobalScopes.php b/v5/Http/Middleware/V5GlobalScopes.php
@@ -19,12 +19,24 @@ public function handle($request, Closure $next)
     {
 
         $isSaving = $request->isMethod('post');
+
         $isPosts = $request->path() === 'api/v5/posts';
         if (!$isSaving && !$isPosts) {
             Category::addGlobalScope(new CategoryAllowed);
             Post::addGlobalScope(new PostAllowed);
             Stage::addGlobalScope(new StageAllowed);
             PostValue::addGlobalScope(new PostValueAllowed);
+            \v5\Models\PostValues\PostDatetime::addGlobalScope(new PostValueAllowed);
+            \v5\Models\PostValues\PostDecimal::addGlobalScope(new PostValueAllowed);
+            \v5\Models\PostValues\PostGeometry::addGlobalScope(new PostValueAllowed);
+            \v5\Models\PostValues\PostInt::addGlobalScope(new PostValueAllowed);
+            \v5\Models\PostValues\PostMarkdown::addGlobalScope(new PostValueAllowed);
+            \v5\Models\PostValues\PostMedia::addGlobalScope(new PostValueAllowed);
+            \v5\Models\PostValues\PostPoint::addGlobalScope(new PostValueAllowed);
+            \v5\Models\PostValues\PostRelation::addGlobalScope(new PostValueAllowed);
+            \v5\Models\PostValues\PostTag::addGlobalScope(new PostValueAllowed);
+            \v5\Models\PostValues\PostText::addGlobalScope(new PostValueAllowed);
+            \v5\Models\PostValues\PostVarchar::addGlobalScope(new PostValueAllowed);
         }
         return $next($request);
     }

diff --git a/v5/Http/Resources/FieldResource.php b/v5/Http/Resources/FieldResource.php
@@ -28,7 +28,7 @@ public function toArray($request)
             'options' => ($this->type === 'tags') ? new CategoryCollection($this->options) : $this->options,
             'cardinality' => $this->cardinality,
             'config' => $this->config,
-            'response_private' => $this->response_private,
+            'response_private' => (boolean) $this->response_private,
             'form_stage_id' => $this->form_stage_id,
             'translations' => new TranslationCollection($this->translations),
         ];