Skip to content

Commit

Permalink
Merge 5b3aa90 into 0e4e8b4
Browse files Browse the repository at this point in the history
  • Loading branch information
rjmackay committed Nov 28, 2018
2 parents 0e4e8b4 + 5b3aa90 commit ab61201
Show file tree
Hide file tree
Showing 20 changed files with 442 additions and 656 deletions.
1 change: 0 additions & 1 deletion app/Console/Kernel.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ class Kernel extends ConsoleKernel
\Ushahidi\Console\Command\ApikeySet::class,
\Ushahidi\Console\Command\ConfigSet::class,
\Ushahidi\Console\Command\ConfigGet::class,
\Ushahidi\Console\Command\Import::class,
\Ushahidi\Console\Command\UserCreate::class,
\Ushahidi\Console\Command\UserDelete::class,
\Ushahidi\Console\Command\Notification::class,
Expand Down
18 changes: 18 additions & 0 deletions app/Http/Controllers/API/CSV/CSVController.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace Ushahidi\App\Http\Controllers\API\CSV;

use Ushahidi\App\Http\Controllers\API\MediaController;
use Illuminate\Http\Request;

/**
* Ushahidi API CSV Controller
Expand All @@ -18,4 +19,21 @@ protected function getResource()
{
return 'csv';
}

public function import(Request $request)
{
/**
* Step two of import.
* Support all line endings without manually specifying it
* (primarily added because of OS9 line endings which do not work by default )
*/
ini_set('auto_detect_line_endings', 1);

$this->usecase = $this->usecaseFactory
->get($this->getResource(), 'import')
->setIdentifiers($this->getRouteParams($request));
;

return $this->prepResponse($this->executeUsecase($request), $request);
}
}
61 changes: 0 additions & 61 deletions app/Http/Controllers/API/CSV/CSVImportController.php

This file was deleted.

34 changes: 34 additions & 0 deletions app/Jobs/ImportPostsJob.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<?php
namespace Ushahidi\App\Jobs;

use Ushahidi\Core\Usecase\CSV\ImportCSVPostsUsecase;
use Ushahidi\Core\Entity\ExportJob;
use Ushahidi\Core\Entity\ExportJobRepository;
use Illuminate\Support\Facades\Log;

class ImportPostsJob extends Job
{
protected $csvId;

/**
* Create a new job instance.
*
* @return void
*/
public function __construct($csvId)
{
$this->csvId = $csvId;
}

/**
* Execute the job.
*
* @return void
*/
public function handle(ImportCSVPostsUsecase $usecase)
{
$usecase->setIdentifiers(['id' => $this->csvId]);

$results = $usecase->interact();
}
}
5 changes: 5 additions & 0 deletions app/Providers/AppServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@ public function registerServicesFromAura()
return service('tool.verifier');
});

$this->app->singleton(\Ushahidi\Core\Usecase\CSV\ImportCSVPostsUsecase::class, function ($app) {
// Just return it from AuraDI
return service('usecase.csv.importposts');
});

$this->app->singleton(\Ushahidi\Core\Usecase\Export\Job\PostCount::class, function ($app) {
return service('factory.usecase')
// Override action
Expand Down
2 changes: 0 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@
"ext-mbstring": "*",
"league/csv": "~7.1@dev",
"laravel/lumen-framework": "5.5.*",
"ddeboer/data-import": "dev-master",
"symfony/property-access": "~2.5",
"league/event": "^2.2@dev",
"beheh/flaps": "dev-master",
"doctrine/cache": "^1.6.2",
Expand Down
138 changes: 2 additions & 136 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion routes/csv.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@
'middleware' => ['auth:api', 'scope:csv', 'expiration']
]);

$router->post('/{id}/import', 'CSVImportController@store');
$router->post('/{id}/import', 'CSVController@import');
});
5 changes: 0 additions & 5 deletions src/App/AppConfig.php
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ public function define(Container $di)
$di->params['Ushahidi\Factory\ValidatorFactory']['map']['posts'] = [
'create' => $di->lazyNew(\Ushahidi\App\Validator\Post\Create::class),
'update' => $di->lazyNew(\Ushahidi\App\Validator\Post\Update::class),
'import' => $di->lazyNew(\Ushahidi\App\Validator\Post\Import::class),
'export' => $di->lazyNew(\Ushahidi\App\Validator\Post\Export::class),
'webhook-update' => $di->lazyNew(\Ushahidi\App\Validator\Post\Create::class),
];
Expand Down Expand Up @@ -753,7 +752,6 @@ public function define(Container $di)
'repo' => $di->lazyGet('repository.post')
];

$di->set('transformer.mapping', $di->lazyNew(\Ushahidi\App\Transformer\MappingTransformer::class));
$di->set('transformer.csv', $di->lazyNew(\Ushahidi\App\Transformer\CSVPostTransformer::class));
// Post repo for mapping transformer
$di->setters[\Ushahidi\App\Transformer\CSVPostTransformer::class]['setRepo'] =
Expand Down Expand Up @@ -800,9 +798,6 @@ public function define(Container $di)
// Add Lock Listener
$di->setters[\Ushahidi\App\Repository\Post\LockRepository::class]['setEvent'] = 'LockBroken';

$di->setters[\Ushahidi\Core\Usecase\ImportUsecase::class]['setEvent'] = 'ImportPosts';
$di->setters[\Ushahidi\Core\Usecase\ImportUsecase::class]['setListener'] =
$di->lazyNew(\Ushahidi\App\Listener\Import::class);
/**
* HXL block
*/
Expand Down

0 comments on commit ab61201

Please sign in to comment.