Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the text link 'Bulk Actions' when there are no posts in a list #3321

Closed
Erioldoesdesign opened this issue Oct 8, 2018 · 4 comments
Closed
Assignees
Labels
Community Task Issues that the Ushahidi OSS community is encouraged to contribute to good-first-issue Issues that are ideal for first time contributors to OSS or first time contributing to the platform Hacktoberfest Issues open to folks participating in hacktoberfest UX/UI debt

Comments

@Erioldoesdesign
Copy link

As a user I don't want to have unnecessary call to action buttons when there is no content that will be affected by the action/function.

When there are no posts in a deployment the 'Bulk Actions' text link should not be clickable and should be in a 'disabled' state.

The 'Bulk Actions' link should still be viewable but clearly not able to be clicked to expand the bulk actions 'menu':

Screen Shot 2018-02-17 at 22.35.59.png

@Erioldoesdesign Erioldoesdesign self-assigned this Oct 8, 2018
@Erioldoesdesign Erioldoesdesign added Community Task Issues that the Ushahidi OSS community is encouraged to contribute to good-first-issue Issues that are ideal for first time contributors to OSS or first time contributing to the platform Hacktoberfest Issues open to folks participating in hacktoberfest UX/UI debt labels Oct 8, 2018
@Erioldoesdesign
Copy link
Author

@rowasc Do you think it's too complex?

@rowasc
Copy link
Contributor

rowasc commented Oct 8, 2018

@Erioldoesdesign this looks like a good first-time-contributor issue

Note: For anyone checking this out/deciding if you want to pick it up:
I think it can be toggled using the $scope.totalItems > 0 as the condition for the link to be disabled/enabled. It's in the post-view-data.html and post-view-data.directive.js files

@jtechera
Copy link

jtechera commented Oct 9, 2018

Starting on this one, if no one is working on it yet.

@rowasc
Copy link
Contributor

rowasc commented Oct 10, 2018

This will go to QA once sad-charlie is free .
Assigning to myself for release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Task Issues that the Ushahidi OSS community is encouraged to contribute to good-first-issue Issues that are ideal for first time contributors to OSS or first time contributing to the platform Hacktoberfest Issues open to folks participating in hacktoberfest UX/UI debt
Projects
None yet
Development

No branches or pull requests

3 participants