Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make registration button and endpoints optional #3918

Closed
rowasc opened this issue Apr 8, 2020 · 8 comments · Fixed by #4135 or ushahidi/platform-client#1602
Closed

Make registration button and endpoints optional #3918

rowasc opened this issue Apr 8, 2020 · 8 comments · Fixed by #4135 or ushahidi/platform-client#1602
Assignees
Labels
Community Task Issues that the Ushahidi OSS community is encouraged to contribute to Theme: Users and roles
Milestone

Comments

@rowasc
Copy link
Contributor

rowasc commented Apr 8, 2020

Which user group(s) are the primary audience for this feature/enhancement.
Include deployment names if possible
A group using Ushahidi for COVID response needs to be able to disable the "Register" functionality.
Their use case is that they explicitly only want people to join if they are invited to be a part of the site management group, rather than make registration open.

Note on user testing:
This is something I can see myself wanting for deployments where there is no reason to register if you aren't an admin, and one that we can see in many content management systems, so while I do not have extensive user tests about this, it's reasonable to assume there is value in having this option, and it is directly coming from a group using Ushahidi.

Is your feature request related to a problem? Please describe.
Yes. Registration should be optional, with administrators being able to just invite people they want to have join their deployment rather than have people signing up all the time without needing to.

Describe the solution you'd like

  • Have a new configuration option "Disable user sign up"
  • The option is OFF by default (meaning user register/sign-up flow is ON by default)
  • When the option is ON:
    • Only users with permissions are allowed to invite others, nobody can register (disable at the API level)
    • Hide the sign up / register button from non-privileged users

Describe alternatives you've considered
Not doing it

Aha! Link: https://ushahiditeam.aha.io/features/PROD-132

@rowasc rowasc added Community Task Issues that the Ushahidi OSS community is encouraged to contribute to Theme: Users and roles labels Apr 8, 2020
@RachealN
Copy link

@rowasc, Here's the solution I thought could work as far as approaching this issue is concerned
1-Make the registration of users strictly by invitation. This approach will not allow public registration and send invitation links instead.
use case

  • Users will be requesting an invite by entering their email and only admin or other management groups will make the registration.
  • This approach will require a new BD table for handling invitations and other configuration options to make it work
    NOTE. This approach can also work for paid membership privileges and pages that are not visible by other users.
    Am requesting you assign this issue to me and I work on it, If you find this approach reliable Thanks

@A-DML
Copy link

A-DML commented Oct 8, 2020

Hi @rowasc @Angamanga i will like to work on this for my outreachy contribution . if it's still available.

@rowasc
Copy link
Contributor Author

rowasc commented Oct 9, 2020

@A-DML please go ahead ! thanks

@rowasc rowasc modified the milestones: Parking Lot, Hacktoberfest Oct 9, 2020
@mohsin
Copy link
Contributor

mohsin commented Oct 20, 2020

@rowasc It's been 2 weeks and I see there has been no progress on this yet. Is this hacktoberfest accepted issue? I'd like to take it up if so.

Also, this config field should appear on the client code i.e. below the Make this deployment private checkbox and the code on this platform side merely updates the configuration internally, correct?

@rowasc
Copy link
Contributor Author

rowasc commented Oct 20, 2020

@A-DML are you working on this? Do you need a hand?
@SaifurRahmanMohsin cc
Thanks

@mohsin
Copy link
Contributor

mohsin commented Oct 25, 2020

@rowasc Hello, I've pushed PRs as per the spec you mentioned in the first comment. Kindly review and merge if everything is well. I would appreciate if this PR includes the hacktoberfest-accepted label. Thank you.

@tuxpiper
Copy link
Member

tuxpiper commented Dec 2, 2020

@all-contributors please add @SaifurRahmanMohsin for code

@allcontributors
Copy link
Contributor

@tuxpiper

I've put up a pull request to add @SaifurRahmanMohsin! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Task Issues that the Ushahidi OSS community is encouraged to contribute to Theme: Users and roles
Development

Successfully merging a pull request may close this issue.

5 participants