Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input type file uses white outline on focus in general settings page #4149

Closed
Ifycode opened this issue Nov 2, 2020 · 0 comments
Closed

Comments

@Ifycode
Copy link
Member

Ifycode commented Nov 2, 2020

Based on the fix I made here in PR 259 that should affect all buttons on the site, button elements that should have been skipped now receive focus - this is the reason why the buttons are not skipped in the screenshot below.

Describe the bug:

Input type file has a white outline when in focus instead of the one applied to other input types.

Screenshot:

Site Settings - Obiagba Mary

Where was the bug observed:

http://localhost:3000/settings/general

Steps to reproduce the behavior:

  1. Login to your account.
  2. Go to setting > general.
  3. Navigate to the input type file with the tab key.

Suggestions:

  • I suggest the same styles applied to the other inputs/textarea should be applied to input type file too (that is if there's no other plan for input type file).
  • Also, what if the generated API key is also made to receive focus?

Aha! Link: https://ushahiditeam.aha.io/features/PROD-893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants