Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4119 - fix focus and for buttons and skipped elements #259

Merged
merged 2 commits into from
Nov 20, 2020
Merged

#4119 - fix focus and for buttons and skipped elements #259

merged 2 commits into from
Nov 20, 2020

Conversation

Ifycode
Copy link
Member

@Ifycode Ifycode commented Oct 31, 2020

This pull request makes the following changes:

Issues, observation & steps taken:

  • Button elements are not focusable. Removed the outline set to none. See associated platform-client PR.
  • In smaller devices, span.mode-context-trigger is skipped. Changed it to button so that focus set for buttons can work on it and also so its role is clear to assistive technology like screen reader.

Testing checklist:

  • Add assets folder from platform-pattern-library containing the new changes made to the platform-client which also contains some new changes and run the project.

  • Login, and use tab key to navigate the toolbar on the map page.

  • Check that buttons are not skipped and in correct order.

  • Check that it is obvious to user that a button is in focus.

  • I certify that I ran my checklist

Fixes ushahidi/platform#4119 .

Ping @ushahidi/platform

@Ifycode
Copy link
Member Author

Ifycode commented Oct 31, 2020

Hi @Angamanga please discard that other PR i started with.

This is the 2nd new PR that deals with buttons (only).
Please help review.

@Angamanga Angamanga changed the base branch from master to v4.4.4 November 20, 2020 11:07
@Angamanga Angamanga merged commit 62dd32b into ushahidi:v4.4.4 Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weak color contrast and issues for tab key users in the map and search area of the map page.
2 participants