Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links and buttons not in the correct tab order in the survey page #4150

Closed
Ifycode opened this issue Nov 2, 2020 · 3 comments · Fixed by ushahidi/platform-pattern-library#262 or ushahidi/platform-client#1631

Comments

@Ifycode
Copy link
Member

Ifycode commented Nov 2, 2020

Based on the fix I made here in PR 259 that should affect all buttons on the site, button elements that should have been skipped now receive focus - this is the reason why the buttons are not skipped in the screenshot below.

Describe the bug:

The bug is noticeable once skipped elements have been fixed. When navigating through the page, buttons and links on the page do not have the correct tab-order. The one on the right receive focus before the one on the left, when it should have been from left to right.

Screenshot:

Surveys - Obiagba Mary

Where was the bug observed:

http://localhost:3000/settings/surveys

Steps to reproduce the behavior:

  1. Login to your account.
  2. Go to setting > surveys.
  3. Navigate the page with the tab key.

Aha! Link: https://ushahiditeam.aha.io/features/PROD-894

@Ifycode
Copy link
Member Author

Ifycode commented Nov 6, 2020

Hi @Angamanga @rowasc, can I work on this?

@Angamanga
Copy link
Contributor

@Ifycode Yes absolutely :)

@Ifycode
Copy link
Member Author

Ifycode commented Nov 25, 2020

Yay! Ok thank you @Angamanga

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

5 participants