1864 changelog backend [WIP] #2127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
October 5, 2017 12:19
willdoran
reviewed
Oct 12, 2017
| * @license https://www.gnu.org/licenses/agpl-3.0.html GNU Affero General Public License Version 3 (AGPL3) | ||
| */ | ||
|
|
||
| use Ushahidi\Core\Exception\FormatterException; |
| $this->changelog_repo = $changelog_repo; | ||
| } | ||
|
|
||
| //TODO: this is ugly, because we're only receiving the ID here. |
| }catch (Exception $e) | ||
| { | ||
| Kohana::$log->add(Log::INFO, 'trying to handle a collection change event.' ); | ||
| } |
There was a problem hiding this comment.
Indenting I think I wrong here too
…m formstages into log
|
@kinstelli I think this is still paused until develop is stable? |
kinstella
changed the title
kinstella
changed the title
|
Closing per agreement that stale PRs won't remain in the list of open PRs. The branch will still be around and the ticket #1864 will remain open when we want to pick it up . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Test checklist:
Fixes ushahidi/platform# .
Ping @ushahidi/platform