New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twitter refactor data #3348
Merged
Merged
Twitter refactor data #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(Twitter): remove message content from twitter, change username to twitter user id in contacts table, make messages.message not null \n This is to comply with GDRP and Twitter ToS per platform#3329
… been copied into the post
rowasc
commented
Oct 23, 2018
public function change() | ||
{ | ||
$this->table('contacts') | ||
->changeColumn('contact', 'string', ['null' => true]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh no this should just be the opposite, null out the contact in message , and keep contact null constraint .
…ter, and they should have been validated as not_empty
…ter, and they should have been validated as not_empty
…ter, and they should have been validated as not_empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Attempts to solve Twitter compliance issues
Tweet content and related data that we had from before we fixed this issue should be removed
posts.content
field matched amessages.message
that was created from a tweet, replaced the message with the tweet's URL.posts.title
field matched amessages.message
that was created from a tweet, replaced the title with 'From Twitter on {date}'`Twitter Usernames should not be saved
New tweets that we extract with
php artisan datasource:incoming
Exports:
Test checklist:
[ ]
I certify that I ran my checklist
Fixes ushahidi/platform# .
Ping @ushahidi/platform