Adding limit check for demo #3357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowasc
reviewed
Oct 25, 2018
rowasc
approved these changes
Oct 31, 2018
|
Export is returning all posts, but I think that was by design , right? The checklist passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Test checklist:
For deployment with 25+ posts you should only ever see the first 25
You should not be able to load more
You should be able to see that you are viewing 25 of real number of posts
You should not be able to get more posts by using the offset
I certify that I ran my checklist
Fixes ushahidi/platform# .
Ping @ushahidi/platform