Hotfix: Avoid duplicate combine jobs #3412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s finish Queue the CombineExportedPostBatchesJob job at the start, and let it keep retrying. Rather than queuing when batches finish and ending up with multiple combine jobs running at once.
rowasc
approved these changes
Nov 26, 2018
|
|
||
| // Queue combine job in 1 min | ||
| dispatch( | ||
| (new CombineExportedPostBatchesJob($this->jobId)) |
There was a problem hiding this comment.
so it does the first try after 1 minute, but if not done, it'll just retry until it can do it, right?
There was a problem hiding this comment.
It'll queue it to run in 1 minute. Then the CombineExportedPostBatchesJob checks if all the batches are done, and if they're not retries in 5 mins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
fix(ExportPosts): Queue combine job at start, rather than when batches finish
Queue the CombineExportedPostBatchesJob job at the start, and let
it keep retrying. Rather than queuing when batches finish and ending
up with multiple combine jobs running at once
Test checklist:
Ping @ushahidi/platform