Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont try to combine failed batches #3415

Merged
merged 2 commits into from Nov 27, 2018

Conversation

rjmackay
Copy link
Contributor

@rjmackay rjmackay commented Nov 27, 2018

This pull request makes the following changes:

  • fix: Exclude failed/pending batches when combining batches …
    We were trying to include failed batches in the combine operation and so it failed when the filename didnt exist
  • refactor: Mark batches as failed if any exception occurs during export

Test checklist:

  • composer test
  • I certify that I ran my checklist

Ping @ushahidi/platform

@rjmackay rjmackay requested a review from rowasc November 27, 2018 01:00
We were trying to include failed batches in the combine operation
and so it failed when the filename didnt exist
@rjmackay rjmackay force-pushed the hotfix/dont-try-to-combine-failed-batches branch from 3253819 to 4812223 Compare November 27, 2018 01:12
@rjmackay rjmackay merged commit 91b8760 into master Nov 27, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 20.513% when pulling 4812223 on hotfix/dont-try-to-combine-failed-batches into 2913f0c on master.

@tuxpiper tuxpiper deleted the hotfix/dont-try-to-combine-failed-batches branch March 24, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants