Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Cache form attributes #3451

Merged
merged 1 commit into from Dec 13, 2018
Merged

feat: Cache form attributes #3451

merged 1 commit into from Dec 13, 2018

Conversation

rjmackay
Copy link
Contributor

@rjmackay rjmackay commented Dec 10, 2018 •
edited

  • Add CachesData trait
  • Use it in Form Attribute Repo to cache basic get requests

Test checklist:

  • composer test
  • I certify that I ran my checklist

Ping @ushahidi/platform

@rjmackay
feat: Cache form attributes
44e0dc2 
- Add CachesData trait
- Use it in Form Attribute Repo to cache basic get requests
@rjmackay rjmackay requested a review from rowasc December 10, 2018 01:04
@rjmackay
Copy link
Contributor Author

@Romina added this to help speed up the importer.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 20.481% when pulling 44e0dc2 on feature/cache-repos into 7876c10 on develop.

@rjmackay rjmackay mentioned this pull request Dec 11, 2018
Merged
2 tasks
@rjmackay rjmackay merged commit 0b8f115 into develop Dec 13, 2018
@rjmackay rjmackay deleted the feature/cache-repos branch December 13, 2018 22:28
@rowasc rowasc mentioned this pull request Aug 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willdoran willdoran willdoran approved these changes

@rowasc rowasc Awaiting requested review from rowasc

@kinstella kinstella Awaiting requested review from kinstella

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rjmackay @coveralls @willdoran