Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue where user could not edit own post #3479

Merged
merged 2 commits into from
Feb 7, 2019

Conversation

willdoran
Copy link
Contributor

@willdoran willdoran commented Jan 29, 2019

This pull request makes the following changes:

Test checklist:

  • Create a survey ensure that 'Hide Author Information" is enabled

  • Make sure no other survey settings are enabled

  • Using a user with member role create a post of this survey type

  • Check that the user can see this post in their data view list

  • Check that the user can edit this post

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

Copy link
Contributor

@rowasc rowasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sane . @willdoran if you push it to a test server , Walter can verify this works

Copy link
Contributor

@rowasc rowasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sane . @willdoran if you push it to a test server , Walter can verify this works

(forgot to approve in prev msg sorry)

@coveralls
Copy link

coveralls commented Jan 29, 2019

Coverage Status

Coverage decreased (-0.002%) to 20.498% when pulling 119d473 on fix-edit-own-post into b4f9889 on production-aws.

@AmTryingMyBest
Copy link
Contributor

QA'd. 👍

@willdoran willdoran merged commit 284fb16 into production-aws Feb 7, 2019
@tuxpiper tuxpiper deleted the fix-edit-own-post branch March 24, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants