Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes XAMPP docs .htaccess code samples. #3482

Merged
merged 2 commits into from
Jun 6, 2019

Conversation

aitorres
Copy link
Contributor

This pull request makes the following changes:

  • Fixes XAMPP docs .htaccess code samples.

Previously, the XAMPP docs had an incorrect formatting of the .htaccess code samples, which were not being rendered properly, both in the Github Markdown parser and through Gitbooks. This PR pretends to fix each code block format in order to be rendered properly. Also, fixes two special symbols that were not being rendered properly.

@ushbot
Copy link
Collaborator

ushbot commented Feb 25, 2019

Hey @aitorres,
thank you for your Pull Request.

It looks like you haven't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@coveralls
Copy link

Coverage Status

Coverage remained the same at 20.544% when pulling e15115d on aitorres:fix-xampp-docs into 7b1aeaf on ushahidi:develop.

@aitorres
Copy link
Contributor Author

[clabot:check]

@ushbot
Copy link
Collaborator

ushbot commented Feb 28, 2019

@rjmackay It looks like @aitorres just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@aitorres
Copy link
Contributor Author

Hello! @rjmackay have you been able to check out this PR?

Copy link
Contributor

@rowasc rowasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New formatting looks good. Thank you !

@rowasc rowasc merged commit d7a1982 into ushahidi:develop Jun 6, 2019
@rowasc
Copy link
Contributor

rowasc commented Sep 12, 2019

@all-contributors please add @aitorres for doc

@allcontributors
Copy link
Contributor

@rowasc

I've put up a pull request to add @aitorres! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants