Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getFormId requires a form_stage_id to find the form_id, in the c… #3557

Merged
merged 3 commits into from
Jun 13, 2019

Conversation

rowasc
Copy link
Contributor

@rowasc rowasc commented Jun 9, 2019

This pull request makes the following changes:
-fix: getFormId requires a form_stage_id to find the form_id, which wee were not sending (this would cause an exception but it looks like we never call it that way)

Test checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

…ase where there is a form_stage_id and not a form_id in selectQuery
@coveralls
Copy link

coveralls commented Jun 9, 2019

Coverage Status

Coverage remained the same at 20.544% when pulling 2d09c35 on fix-select-query-how-did-this-ever-work into d7a1982 on develop.

@Angamanga Angamanga merged commit d4b622d into develop Jun 13, 2019
@tuxpiper tuxpiper deleted the fix-select-query-how-did-this-ever-work branch March 24, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants