Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(3836): roles error message when creating should reflect the problem instead of a generic runtime error #3837

Merged
merged 2 commits into from Mar 16, 2020

Conversation

rowasc
Copy link
Contributor

@rowasc rowasc commented Jan 30, 2020

This pull request makes the following changes:

  • Uses the update role rules + the create rules merged recursively so that it doesn't just override the name rules in one of them
  • stops throwing a runtime exception for roles creation errors 🤷‍♂ 🤷‍♀

Test checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes #3836 .

Ping @ushahidi/platform

@rowasc
Copy link
Contributor Author

rowasc commented Mar 11, 2020

@Angamanga @tuxpiper I apparently forgot to ask for a code review here. If anyone has some bandwidth, check it out :D this basically makes it so that we don't throw runtime errors to users and fixes the create rules for roles which were just overriding the name validation 😬

Copy link
Member

@tuxpiper tuxpiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Angamanga Angamanga merged commit 6f46072 into develop Mar 16, 2020
@tuxpiper tuxpiper deleted the 3836-fix-ohanzee-runtime branch March 24, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error-message when trying to create new role is not making sense
3 participants