fix(perf): cache media storage url #3917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowasc
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
Looks sane. Let's get this tested.
Nitpick for future PRs is to maybe go with double quotes rather than single for string interpolation
"Ushahidi\App\Formatter\Media.publicUrl[$path]" when possible, which I find generally more readable but you can argue you find this more legible so it's a matter of preference to discuss, I guess
|
@Obadha2 can we have this tested today? |
|
Tried this in steve, it looks great 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Test checklist:
verify several times that photos are available in posts
I certify that I ran my checklist
Fixes ushahidi/platform# .
Ping @ushahidi/platform