[draft!] New endpoints for entity translations and using lumen #3964
Conversation
… when the user has the right perms.
…ge permissions are correct
| @@ -39,7 +39,7 @@ public function isPrivate() | |||
| * Check if user can access deployment | |||
| * @return boolean | |||
| */ | |||
| public function canAccessDeployment(User $user) | |||
| public function canAccessDeployment($user) | |||
There was a problem hiding this comment.
removed type hint here because of an issue with the user I'm sending now but making a note to reconsider since it'd be better just to send the correct user entity even if I have to cast it for the moment
| - | ||
| id: 2 | ||
| form_id: 1 | ||
| label: "2nd step" | ||
| show_when_published: 1 | ||
| task_is_internal_only: 0 | ||
| type: "task" | ||
| priority: 2 |
There was a problem hiding this comment.
ok so this is actually important/good: we are being explicit about priorities to be able to test things more safely, especially the order of how we return things.
| @@ -1,4 +1,4 @@ | |||
| <?php | |||
| <?php /** @noinspection ALL */ | |||
There was a problem hiding this comment.
mmm this may be a phpstorm thing, TODO check
| @@ -0,0 +1,165 @@ | |||
| @acl | |||
There was a problem hiding this comment.
this is similar to our acl.feature with minimal changes and some improvement on what we check and of course hydrated entities
| */ | ||
| public function translations() | ||
| { | ||
| return $this->morphMany('v4\Models\Translation', 'translatable'); |
There was a problem hiding this comment.
Polymorphic relations are really useful here, because we can easily have translations for all entities
| * | ||
| * @var array | ||
| */ | ||
| protected $appends = ['can_create']; |
There was a problem hiding this comment.
this makes it so that calculated properties like can_create make it cleanly into the json responses we send
v4/Models/Survey.php
Outdated
| * We check for relationship permissions here, to avoid hydrating anything that should not be hydrated. | ||
| * @return \Illuminate\Database\Eloquent\Relations\HasMany | ||
| */ | ||
| public function stages() |
There was a problem hiding this comment.
this is actually kind of nice? Not loving the usage of v3 authorizers but not much to do there. The good part is that we just do it in the hydration and it works seamlessly with the ->stages relation.
…add and fix some more tests
… a lot of weird frontend logic needed
…ed stages with updates)
…ore now with hydrated forms
Started this to comment with @tuxpiper as I go