Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: geolocation locale #4056

Merged
merged 1 commit into from Aug 25, 2020
Merged

fix: geolocation locale #4056

merged 1 commit into from Aug 25, 2020

Conversation

leninpaulino
Copy link
Contributor

This pull request makes the following changes:

  • Fix the locale param, use the app locale if not sent

Test checklist:

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

@leninpaulino leninpaulino changed the base branch from develop to geolocation-service August 25, 2020 05:45
@coveralls
Copy link

Coverage Status

Coverage remained the same at 20.346% when pulling 9f15eaa on feat-geolocation-locale into 5f9fb73 on geolocation-service.

@tuxpiper
Copy link
Member

Makes sense to me 👍

@tuxpiper tuxpiper merged commit 256f138 into geolocation-service Aug 25, 2020
@tuxpiper tuxpiper deleted the feat-geolocation-locale branch August 25, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuxpiper tuxpiper Awaiting requested review from tuxpiper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leninpaulino @coveralls @tuxpiper