Update UpdatePostCommand.php #4672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're making an update, there's no reason to updating the created column.
USH-1007 Changes to newly created posts can't be saved successfully
|
webong
force-pushed
the
hotfix/USH-1007
branch
from
2f72be6
to
06d4857
Compare
webong
force-pushed
the
hotfix/USH-1007
branch
from
06d4857
to
dacf75d
Compare
Merged
ushahidlee
added a commit
that referenced
this pull request
Jan 8, 2024
* Update UpdatePostCommand.php (#4672) * Update UpdatePostCommand.php Since we're making an update, there's no reason to updating the created column. * fix: ensure Timestamp is correct before updating entity * chore: use laravel config to retrieve settings in V5 config handler * refactor: update eloquent repo for category * chore: work on the places we use the data source label * chore: fix lint in EloquentPostRepository * test: resolve failing test for V3 endpoints * chore: update create post command to record post source * fix lint * fix: fallback to null when user attribute value is undefined * fix config data permission * fix the issue of returned fromated created value * Update usersetting to accept config value as array --------- Co-authored-by: Wisdom Ebong <30173059+webong@users.noreply.github.com> Co-authored-by: Wisdom Ebong <wisdom@ushahidi.com> Co-authored-by: Mh-Asmi <mnaasmi@gmail.com> Co-authored-by: ushahidlee <152860706+ushahidlee@users.noreply.github.com>
tuxpiper
added a commit
that referenced
this pull request
Jan 15, 2024
* Update UpdatePostCommand.php (#4672) * Update UpdatePostCommand.php Since we're making an update, there's no reason to updating the created column. * fix: ensure Timestamp is correct before updating entity * chore: use laravel config to retrieve settings in V5 config handler * refactor: update eloquent repo for category * chore: work on the places we use the data source label * chore: fix lint in EloquentPostRepository * test: resolve failing test for V3 endpoints * chore: update create post command to record post source * fix lint * fix: fallback to null when user attribute value is undefined * fix config data permission * fix the issue of returned fromated created value * Update usersetting to accept config value as array --------- Co-authored-by: Wisdom Ebong <30173059+webong@users.noreply.github.com> Co-authored-by: Wisdom Ebong <wisdom@ushahidi.com> Co-authored-by: Mh-Asmi <mnaasmi@gmail.com> Co-authored-by: ushahidlee <152860706+ushahidlee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Fixes USH-1007 .
Ping @ushahidi/platform