Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix contact filter for v5 get messages #4702

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix contact filter for v5 get messages #4702

merged 1 commit into from
Jan 16, 2024

Conversation

Mh-Asmi
Copy link
Contributor

@Mh-Asmi Mh-Asmi commented Jan 16, 2024

This pull request makes the following changes:

  • in src/Ushahidi/Modules/V5/Repository/Message/EloquentMessageRepository.php , fix the filter condition to use where equal instead of where in.

Test checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

@linear Linear
Copy link

linear bot commented Jan 16, 2024

USH-1091 get message return error for contact filter

@Mh-Asmi Mh-Asmi changed the base branch from develop to release/2024.03 January 16, 2024 08:57
@webong
Copy link
Collaborator

webong commented Jan 16, 2024

Looks good to me!

@webong webong merged commit 7615477 into release/2024.03 Jan 16, 2024
4 checks passed
@tuxpiper
Copy link
Member

Ported to develop branch as well

@Mh-Asmi Mh-Asmi deleted the USH-1091 branch May 17, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webong webong webong approved these changes

@ushahidlee ushahidlee Awaiting requested review from ushahidlee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mh-Asmi @webong @tuxpiper