Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return all permissions for admin role #4717

Merged
merged 2 commits into from
Feb 13, 2024
Merged

return all permissions for admin role #4717

merged 2 commits into from
Feb 13, 2024

Conversation

Mh-Asmi
Copy link
Contributor

@Mh-Asmi Mh-Asmi commented Feb 13, 2024

This pull request makes the following changes:

  • I update the sho of role to return all available permissions when the role is admin
  • I create migration to adding the missing permissions for admin

Test checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

@linear Linear
Copy link

linear bot commented Feb 13, 2024

USH-1071 Editing the admin role displays wrong permissions

ushahidlee
ushahidlee approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@ushahidlee ushahidlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good and works as described

@Mh-Asmi Mh-Asmi merged commit 87a1886 into develop Feb 13, 2024
4 checks passed
@Mh-Asmi Mh-Asmi deleted the USH-1071 branch May 17, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ushahidlee ushahidlee ushahidlee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mh-Asmi @ushahidlee