ブログ記事詳細ページの title が反映されるように設定 #12
Merged
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yamanoku
commented
Apr 6, 2023
yamanoku
commented
| 変更前 | 変更後 |
|---|---|
| 
|
|
Someone is attempting to deploy a commit to a Personal Account owned by @ushironoko on Vercel. @ushironoko first needs to authorize it. |
yamanoku
commented
Apr 6, 2023
src/pages/posts/[id].vue
Outdated
| @@ -25,7 +28,7 @@ useHead({ | |||
| }, | |||
| { | |||
| name: 'twitter:title', | |||
| content: data.value?.title ?? 'ushironoko.me', | |||
| content: postTitle ?? 'ushironoko.me', | |||
There was a problem hiding this comment.
同等の値があったので併せて変数にしておきました
There was a problem hiding this comment.
これだったらpostTitle自体を data.value?.contentHtml ?? 'ushironoko.me' にしたほうがよくないですか？
There was a problem hiding this comment.
contentHtml => title ですかね。たしかに。
There was a problem hiding this comment.
でもsite_nameはushironoko.meだなー（元々の設定がわるい）
There was a problem hiding this comment.
b5510c2 で site_name だけ ushironoko.me にしました
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.