Temporary work around a crash for the release

usineur · Dec 14, 2016 · efb370c · efb370c
1 parent 24c49b5
commit efb370c
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 11 deletions.
diff --git a/Source/Objects/Person.cpp b/Source/Objects/Person.cpp
@@ -2147,7 +2147,7 @@ void Person::DoAnimations()
             animCurrent = animTarget;
             frameTarget++;
 
-            if (animTarget == removeknifeanim && Animation::animations[animTarget].frames[frameCurrent].label == 5) {
+            if (animTarget == removeknifeanim && currentFrame().label == 5) {
                 for (unsigned i = 0; i < weapons.size(); i++) {
                     if (weapons[i].owner == -1)
                         if (distsqflat(&coords, &weapons[i].position) < 4 && weaponactive == -1) {
@@ -2162,7 +2162,7 @@ void Person::DoAnimations()
                 }
             }
 
-            if (animTarget == crouchremoveknifeanim && Animation::animations[animTarget].frames[frameCurrent].label == 5) {
+            if (animTarget == crouchremoveknifeanim && currentFrame().label == 5) {
                 for (unsigned i = 0; i < weapons.size(); i++) {
                     bool willwork = true;
                     if (weapons[i].owner != -1)
@@ -2238,7 +2238,7 @@ void Person::DoAnimations()
                 }
             }
 
-            if (animCurrent == drawleftanim && Animation::animations[animTarget].frames[frameCurrent].label == 5) {
+            if (animCurrent == drawleftanim && currentFrame().label == 5) {
                 if (weaponactive == -1)
                     weaponactive = 0;
                 else if (weaponactive == 0) {
@@ -3734,7 +3734,7 @@ void Person::DoAnimations()
 
 
             //Animation end
-            if (frameTarget > int(Animation::animations[animCurrent].frames.size()) - 1) {
+            if (frameTarget >= int(Animation::animations[animCurrent].frames.size())) {
                 frameTarget = 0;
                 if (wasStop()) {
                     animTarget = getIdle();
@@ -4161,9 +4161,9 @@ void Person::DoAnimations()
                     /* FIXME - mixed of target and current here, is that intended? */
                     target += multiplier * Animation::animations[animTarget].frames[frameCurrent].speed * speed * 1.7 * tempspeed / (speed * 45 * scale);
                 }
-            } else if (transspeed)
+            } else if (transspeed) {
                 target += multiplier * transspeed * speed * 2;
-            else {
+            } else {
                 if (!isRun() || !wasRun()) {
                     if (targetFrame().speed > currentFrame().speed)
                         target += multiplier * targetFrame().speed * 2;
@@ -4179,6 +4179,11 @@ void Person::DoAnimations()
                 frameCurrent = frameTarget;
                 target = 1;
             }
+
+            if (frameCurrent >= int(Animation::animations[animCurrent].frames.size())) {
+                frameCurrent = Animation::animations[animCurrent].frames.size() - 1;
+            }
+
             oldrot = rot;
             rot = targetrot * target;
             yaw += rot - oldrot;
@@ -4187,9 +4192,7 @@ void Person::DoAnimations()
                 oldrot = 0;
                 targetrot = 0;
             }
-            if (frameCurrent >= int(Animation::animations[animCurrent].frames.size())) {
-                frameCurrent = Animation::animations[animCurrent].frames.size() - 1;
-            }
+
             if (animCurrent != oldanimCurrent || animTarget != oldanimTarget || ((frameCurrent != oldframeCurrent || frameTarget != oldframeTarget) && !calcrot)) {
                 //Old rotates
                 for (unsigned i = 0; i < skeleton.joints.size(); i++) {

diff --git a/Source/Objects/Person.hpp b/Source/Objects/Person.hpp
@@ -327,8 +327,32 @@ class Person : public enable_shared_from_this<Person>
     inline Joint& joint(int bodypart) { return skeleton.joints[skeleton.jointlabels[bodypart]]; }
     inline XYZ& jointPos(int bodypart) { return joint(bodypart).position; }
     inline XYZ& jointVel(int bodypart) { return joint(bodypart).velocity; }
-    inline AnimationFrame& currentFrame() { return Animation::animations.at(animCurrent).frames.at(frameCurrent); }
-    inline AnimationFrame& targetFrame() { return Animation::animations.at(animTarget).frames.at(frameTarget); }
+    AnimationFrame& currentFrame() {
+        /* FIXME - try/catch is a temporary fix to avoid crashes but game logic should be fixed instead */
+        try {
+            return Animation::animations.at(animCurrent).frames.at(frameCurrent);
+        } catch (const std::exception& error) {
+            /* Most likely frameCurrent is too big, work around */
+            if ((unsigned)frameCurrent >=
+Animation::animations.at(animCurrent).frames.size()) {
+                frameCurrent = Animation::animations.at(animCurrent).frames.size() - 1;
+            }
+            return Animation::animations.at(animCurrent).frames.back();
+        }
+    }
+    AnimationFrame& targetFrame() {
+        /* FIXME - try/catch is a temporary fix to avoid crashes but game logic should be fixed instead */
+        try {
+            return Animation::animations.at(animTarget).frames.at(frameTarget);
+        } catch (const std::exception& error) {
+            /* Most likely frameTarget is too big, work around */
+            if ((unsigned)frameTarget >=
+Animation::animations.at(animTarget).frames.size()) {
+                frameTarget = Animation::animations.at(animTarget).frames.size() - 1;
+            }
+            return Animation::animations.at(animTarget).frames.back();
+        }
+    }
 
 
     void CheckKick();