Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better expectations examples #17

Open
mcbridem opened this issue Apr 13, 2018 · 2 comments
Open

Add better expectations examples #17

mcbridem opened this issue Apr 13, 2018 · 2 comments

Comments

@mcbridem
Copy link
Contributor

We should at least document this:

## Canonical check
-   directive: check
    url: https://www.usnews.com
    html:
    -   selector: link[rel="canonical"]
        attribute: href
        equals: https://www.usnews.com

There's no mention of this attribute key in the repository currently, as far as I can tell.

Adding some actual example expectations files might also be nice.

@mcbridem
Copy link
Contributor Author

Oh, I was looking in my expectations repository, not in this repository. D'oh. :-(

@mcbridem
Copy link
Contributor Author

mcbridem commented May 9, 2018

I think including an example YAML file, even if it's only testing one URL using lots or all of the available features, would be really helpful.

malerichc added a commit to malerichc/smoketest that referenced this issue May 18, 2022
Add example expectations files that show most of the available features
for usnews#17.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant