Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping of Properties in OSCAL documents other than Catalog #1064

Closed
3 of 7 tasks
degenaro opened this issue Dec 6, 2021 · 6 comments · Fixed by #1412
Closed
3 of 7 tasks

Grouping of Properties in OSCAL documents other than Catalog #1064

degenaro opened this issue Dec 6, 2021 · 6 comments · Fixed by #1412
Assignees
Labels
enhancement Scope: Modeling Issues targeted at development of OSCAL formats User Story
Milestone

Comments

@degenaro
Copy link

degenaro commented Dec 6, 2021

User Story:

As an OSCAL tool developer, I would like Properties to be optionally groupable in order to differentiate different sets of Properties from each other.

For example: one set of Properties may apply at integration time while another set of Properties may apply at deployment time; or one set of Properties may apply during development while a different set of Properties may apply during production.

An existing grouping example is under OSCAL Catalog, where Group is permitted to contain params, props...groups. It would be useful to have a grouping mechanism especially for Properties in other documents such as Component Definition, Profile and Assessment Results.

Goals:

The ability to group Properties in in OSCAL documents besides Catalog, such as Component Definition, Profile and Assessment Results.

  • Add a group flag to the property Metaschema definition
  • Develop a concrete example
  • Socialize this during an OSCAL model review.
  • Collect feedback, and identify any follow-on work if needed.

Dependencies:

N/A

Acceptance Criteria

  • All OSCAL website and readme documentation affected by the changes in this issue have been updated. Changes to the OSCAL website can be made in the docs/content directory of your branch.
  • A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.

{The items above are general acceptance criteria for all User Stories. Please describe anything else that must be completed for this issue to be considered resolved.}

@david-waltermire
Copy link
Contributor

It was proposed on the 12/10/2021 model review to add a new flag that would allow for grouping of related properties. This grouping would be scoped to the containing object. A UUID can be used as the grouping value (or maybe a token).

We need some concrete XML, JSON, or YAML examples of what this would look like. @degenaro can you provide some?

@degenaro
Copy link
Author

Here's an example of using remarks to form groups (thanks, Vikas).

profile.json.zip

@aj-stein-nist
Copy link
Contributor

Thanks for the contribution, @degenaro and @vikas-agarwal76. We shall take a look. In the future, you might benefit from using GitHub Gists like this to post examples for issues to refine samples!

@david-waltermire david-waltermire added the Scope: Modeling Issues targeted at development of OSCAL formats label Jan 21, 2022
@david-waltermire david-waltermire added this to the OSCAL 1.1.0 milestone Jan 21, 2022
@david-waltermire david-waltermire added this to Need Triage in Issue Triage via automation Mar 4, 2022
@david-waltermire david-waltermire moved this from Need Triage to Discussion Needed in Issue Triage Mar 4, 2022
@david-waltermire
Copy link
Contributor

This has been discussed on a previous OSCAL model review. An option that was discussed was to add a grouping flag to a property and link to allow grouped properties and links to identify their grouping. We should work up a proposal for how this might work.

@aj-stein-nist
Copy link
Contributor

@david-waltermire-nist, where should I set up a concrete example so I can socialize and work down the goals and AC checklist for the issue?

aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Aug 12, 2022
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Aug 12, 2022
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Aug 12, 2022
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Aug 12, 2022
@david-waltermire
Copy link
Contributor

This has been merged into develop and will be included in OSCAL 1.1.

Issue Triage automation moved this from Allocated to Milestone to Done Aug 21, 2022
@oscalbuilder oscalbuilder removed this from Done in Issue Triage Aug 21, 2022
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment