Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken arithmetic face to cell distance calculations #180

Closed
wd15 opened this issue Sep 19, 2014 · 3 comments
Closed

broken arithmetic face to cell distance calculations #180

wd15 opened this issue Sep 19, 2014 · 3 comments
Labels

Comments

@wd15
Copy link
Contributor

wd15 commented Sep 19, 2014

The two tests starting [trunk/fipy/variables/cellVariable.py@3037#L303 here] are complete nonsense! We used the same broken calculation to derive the answer as we used in [trunk/fipy/variables/arithmeticCellToFaceVariable.py@3037#L45 _ArithmeticFaceToCellVariable]. Thanks to William Gathright for rasing this issue [http://thread.gmane.org/gmane.comp.python.fipy/1458 here], he noticed that the gradients were broken.

Imported from trac ticket #195, created by wd15 on 07-31-2009 at 18:15, last modified: 09-30-2013 at 21:44

@wd15
Copy link
Contributor Author

wd15 commented Sep 19, 2014

fixed with r3194

Trac comment by wd15 on 08-03-2009 at 18:56

@fipymigrate
Copy link

In b8f7aac:

#CommitTicketReference repository="fipy" revision="b8f7aac412c3d97300b06bbd8236cb682e0862bd"
fixed issue #180

git-svn-id: svn+ssh://code.matforge.org/fipy/branches/version-2_0@3194 d80e17d7-ff13-0410-a124-85740d801063

Trac comment by Daniel Wheeler daniel.wheeler@nist.gov on 06-12-2013 at 14:14

@guyer
Copy link
Member

guyer commented Sep 19, 2014

Marking milestone

Trac comment by guyer on 09-30-2013 at 21:44

@wd15 wd15 closed this as completed Sep 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants