Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not available on npm? #7

Closed
pzi opened this issue Apr 9, 2020 · 19 comments
Closed

Not available on npm? #7

pzi opened this issue Apr 9, 2020 · 19 comments

Comments

@pzi
Copy link

pzi commented Apr 9, 2020

Hi, thanks for maintaining jsfive!

Quick question: how come this package is not available on NPM?
Are there any legal reasons for it to not be published?

Cheers & thanks again
Patrik

@bmaranville
Copy link
Member

bmaranville commented Apr 9, 2020 via email

@pzi
Copy link
Author

pzi commented Apr 14, 2020

Hi Brian,

Of course pull requests are fine. No need to be added to your organisation as collaborator.

In my case, I wanted to avoid having a dependency on a GitHub package/project because if the repository gets renamed/moved/changed/deleted, the app I am working on will fail to install & build. I will see what I can do to help with getting it on NPM.

Cheers
Patrik

@pzi
Copy link
Author

pzi commented Apr 20, 2020

Hi Brian,

Are you able to publish jsfive to Github packages for now please? (I noticed NPM has been acquired by GitHub recently).

Regards & thanks
Patrik

@bmaranville
Copy link
Member

Hi, Patrik. I have published the package to github packages. Please see https://github.com/usnistgov/jsfive/packages

@bmaranville
Copy link
Member

Note that you have to authenticate to github before you can install these... I was unaware of this restriction. See discussion at https://github.community/t5/GitHub-API-Development-and/Download-from-Github-Package-Registry-without-authentication/td-p/35255

@bmaranville
Copy link
Member

I'm having trouble getting the package to publish properly.

@pzi
Copy link
Author

pzi commented Apr 23, 2020

Not sure if it helps your situation, but I found this tool quite helpful with publishing packages: https://github.com/sindresorhus/np

This should also make it simpler to publish it to NPM if you would still consider that.

@bmaranville
Copy link
Member

Thanks, Patrik - I think we are encountering a bug in github, though - something other people have experienced also, related to billing of data output (which shouldn't apply to public repositories which have free data, hence it is a billing bug). I was able to publish in a test fork in a different organization with the same settings, and it worked fine. Hopefully the bug will be fixed soon, and I will re-publish.

@obermillerk
Copy link

What is preventing this from being properly published on npm? I'd rather not have to deal with a second package registry, and the github registry requiring authentication to pull packages complicates things even more.

@bmaranville
Copy link
Member

bmaranville commented Jul 10, 2020 via email

@obermillerk
Copy link

That doesn't really answer the part about releasing it properly on npm. I would think it'd be easier just to npm publish it, and then it's available as people would normally expect

@bmaranville
Copy link
Member

bmaranville commented Jul 10, 2020 via email

@obermillerk
Copy link

In the meantime, would it be possible to make a tag for the 0.2.0 release in the repository that seems to be on github packages?

@bmaranville
Copy link
Member

The release is still not working on github packages... the download link is broken, so there's no way to install from github even if you authenticate.

@obermillerk
Copy link

If you just tag the commit I can reference that and circumvent github packages entirely and point it to the github repository. The last tag I see presently is 0.1.6

@bmaranville
Copy link
Member

Ah I'm glad you can work around it!

I just made a release 0.2.1 that matches the package.json version information. Sorry for all the version churn. Nothing really changed since release 0.1.6 but iIt took me quite a while to figure out what was going on with the package system on github. I didn't believe that it was just broken for a while.

@obermillerk
Copy link

Much appreciated, as are the quick responses!

@bmaranville
Copy link
Member

package has been published to npm

@pzi
Copy link
Author

pzi commented Jul 20, 2020

Great outcome, thanks @bmaranville 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants