Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More testing #122

Merged
merged 6 commits into from
Jul 22, 2024
Merged

Conversation

wendellpiez
Copy link
Collaborator

XSpec and make invocations providing and exposing more testing.

Committer Notes

At a high level, this PR will include:

  • More and improved Makefile logic invoking XSpec and other testing across the repo
  • More XSpec, for example in /src/testing for test models

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

Copy link

github-actions bot commented Jun 11, 2024

XSpec Test Results

  5 files  ±0   93 suites  +3   0s ⏱️ ±0s
232 tests +3  215 ✅ +2  17 💤 +1  0 ❌ ±0 
243 runs  +4  225 ✅ +2  18 💤 +2  0 ❌ ±0 

Results for commit be24d47. ± Comparison against base commit 52c9f6d.

This pull request removes 8 and adds 11 tests. Note that renamed tests count towards both.
And similarly Corresponds to the cached testing copy
Nested choices expands into four (2 x 2)
[A.1] A simple model passes through
[A.1] Comment is dropped
[A.2] A model with a choice expands into two
[A.2] Processing instruction is dropped
[A.3] A kind-of crazy case expands into twelve (2 x 2 x 3)
[B.1] The 'sheet' assembly (with a choice) Is consistent with the handmade corrected model
Basic metaschema composition
Local definitions preserved with amended names
Modules collected, no loops
an exception is reported for the unused assembly
an exception is reported for the unused field
exactly two unused definitions are reported as exceptions
no assembly is defined for an assembly named 'unused-assembly'
no field is defined for a field named 'unused-field'
only a top-level METASCHEMA is given
the unused definitions are detected and replaced
…
This pull request removes 1 skipped test and adds 2 skipped tests. Note that renamed tests count towards both.
Nested choices expands into four (2 x 2)
Basic metaschema composition
Local definitions preserved with amended names

♻️ This comment has been updated with latest results.

@wendellpiez wendellpiez marked this pull request as ready for review June 27, 2024 19:53
@wendellpiez wendellpiez requested a review from a team as a code owner June 27, 2024 19:53
Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor feedback, I am presuming the ./current folder is being deleted so testing will locally output there in cloned copies on a developer workstation, but not make the git history for this output directory too busy. I can agree with that change, and of course the others put forth here. Nice work, Wendell.

Nice

Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
@wendellpiez wendellpiez merged commit 4e31191 into usnistgov:merge-June2024 Jul 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants