Metaschema XSLT Inspector #73
Conversation
wendellpiez
force-pushed
the
issue72-XSLT-inspectorA
branch
from
71280de
to
1e49440
Compare
|
See wiki page here: https://github.com/usnistgov/metaschema-xslt/wiki/InspectorXSLT Discussion board to come (watch for link). |
There was a problem hiding this comment.
Initial feedback, but more to follow with an approval later today or tomorrow when I experiment with it more and make sure I don't find any major problems. Looks good so far. I know we discussed README organization and separation. I would think it is better to make it in a different repo to not confuse consumers of this repo, but you are the maintainer. Not my repo! :-)
|
Closes #72 |
|
Holding back pending
|
…new invalid sample; Schematron for XSLT line number alignment assurance.
…, with metaschema mod illustrating a choice; two new samples.
… refining tests and reports - wip
…a 1.0 delta, with XSpec updates
aj-stein-nist
force-pushed
the
issue72-XSLT-inspectorA
branch
2 times, most recently
from
049e94b
to
f773efd
Compare
This change integrates the Makefile-based testing harness for each of the submodules. For the InspectorXSLT submodule in the schema-gen directory, integrate the shell script that orchestrates Maven's installation of dependencies and execution of XML Calabash to run XProc files. The XProc pipeline files will run the XSpec tests in batch mode.
aj-stein-nist
force-pushed
the
issue72-XSLT-inspectorA
branch
from
f773efd
to
e675ca9
Compare
There was a problem hiding this comment.
@wendellpiez, I am re-reviewing and approving at the time of this message to signal I am happy with the current version of the CI additions, now with more STDOUT and STDERR logging to move us forward. If you want me to re-review after you add relevant documentation, feel free to do so, but I already reviewed the other XSLT, XSpec, XProc, and shell script changes here as needed to advance this work.
|
@aj-stein-nist please feel free to re-review changes -- mainly in TESTING.md documentation (not perfect yet but better), plus also a couple of tweaks elsewhere. The remaining desideratum for this Issue is to have CI on a PR report failure not only for broken runs but also for successful runs reporting test failures. I have vacillated but I think this is more or less essential. A cheap/dirty way to do this is by inspecting the outputs for key (regex) match patterns. And there could be better options. (Maybe our testing could produce a format that Github Actions could use?) Happy for any thoughts. |
|
In the current 'integration tests' (smoke tests) we have failures successfully reported by at least one XSpec - We have the option of making either script or XSLT runtime error out, but it makes sense to catch this gracefully, non? (Unless an actual reporting-XML concept takes hold.) |
…es for JUnit XML test results to be produced and written.
* Metaschema XSLT Inspector (#73) Several months of work building InspectorXSLT using test-driven-development. Also includes considerable work on XSpec support including XProc and Saxon runtimes, scripts and CI/CD support. --------- Co-authored-by: A.J. Stein <alexander.stein@nist.gov> * Update XSPEC-BATCH.xsl On-the-fly modification of JUnit XML results * Adjustments to XSpec reporting under CI (#99) * Fine adjustments in prep for 'nearly good enough' XSpec support under ci/cd (in feature branch) * Adjustments for legibility * Another touchup * Buffs in view of CI/CD and local/CL use cases for testing under make including new error-on-fail option * Added to script documentation * Still polishing help msg * Now with some more nicer XProc and scripting supporting ongoing maintenance / dev * adjustments to test runtime * Further refinements to testing & scripts * Rationalizing including file name regularization * Further configuration enhancements * More help in docs * Further testing/tuning/tweaking test runtimes and docs * Further alignment * New 'quiet' XSpec batching script, plus adjustment * New 'make' feature for testing InspectorXSLT * More Makefile edits / cleanup * Further docs and readme improvements * Removed obsolete Schematron implementation, no longer of interest * More polishing * Further small but useful improvements and cleanup * Added another utility script * Continuing to touch up * Add permissions for EnricoMi/publish-unit-test-result-action Using the guidance from the action's instructions: https://github.com/EnricoMi/publish-unit-test-result-action?tab=readme-ov-file#support-fork-repositories-and-dependabot-branches * Add artifact event pull for EnricoMi/publish-unit-test-result-action Using the guidance from the action's instructions: https://github.com/EnricoMi/publish-unit-test-result-action?tab=readme-ov-file#support-fork-repositories-and-dependabot-branches * Ensure XSpec test results comment always made on PR * [WIP] Dedupe event trigger and inline JUnit XML processing in CI workflow --------- Co-authored-by: A.J. Stein <alexander.stein@nist.gov> --------- Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
Several months of work building InspectorXSLT using test-driven-development. Also includes considerable work on XSpec support including XProc and Saxon runtimes, scripts and CI/CD support. --------- Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
…gov#73) Several months of work building InspectorXSLT using test-driven-development. Also includes considerable work on XSpec support including XProc and Saxon runtimes, scripts and CI/CD support. --------- Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
Committer Notes
Working towards #72
All Submissions:
Changes to Core Features: