Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple callresults #6

Merged
merged 2 commits into from
Jan 21, 2019
Merged

Multiple callresults #6

merged 2 commits into from
Jan 21, 2019

Conversation

yancouto
Copy link
Collaborator

Depends on #5

Before this PR, if you did two calls with callresults at the same time (for example, requesting different leaderboars), one of them wouldn't work. For example:

Steam.userStats.downloadLeaderboardEntries(lb_handle, "Global", 1, 10000, function(results, err)
    -- Download global stats
end)
Steam.userStats.downloadLeaderboardEntries(lb_handle, "Friends", function(results, err)
    -- Download friends stats
end)

This is very useful, like to download multiple entries, or to download data from multiple leaderboards at the same time.

With this PR each call creates its own listener that stores the callback, so it works.

@yancouto yancouto mentioned this pull request Jan 12, 2019
@yancouto yancouto force-pushed the master branch 8 times, most recently from cc1bfaf to 7592a6f Compare January 13, 2019 03:30
Before this commit, if you did two calls with callresults at the same time (for example, requesting different leaderboars), one of them wouldn't work.

Now each call creates its own listener that stores the callback, so it works.
@yancouto
Copy link
Collaborator Author

(Rebase on master after #5 was merged)

Copy link
Member

@rilifon rilifon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming you tested the functions on some project

@rilifon rilifon merged commit 6ee22d9 into master Jan 21, 2019
@yancouto yancouto deleted the multiple_callresults branch January 21, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants