Skip to content

Commit

Permalink
Merge pull request #3 from unkiwii/master
Browse files Browse the repository at this point in the history
Fixed some issues with logs
  • Loading branch information
pfumagalli committed Jan 11, 2017
2 parents 1cb0927 + 9c6225f commit a97f486
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 5 deletions.
6 changes: 5 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "karma-verbose-reporter",
"version": "0.0.3",
"version": "0.0.4",
"description": "A Karma reporter bringing verbosity to the max.",
"main": "reporter.js",
"repository": {
Expand All @@ -15,6 +15,10 @@
"name": "Pier Fumagalli",
"email": "pier@usrz.com"
},
"contributors": [{
"name": "Lucas G. Sánchez",
"email": "unkiwii@gmail.com"
}],
"dependencies": {
"colors": ">=1.0"
},
Expand Down
15 changes: 11 additions & 4 deletions reporter.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require('colors');
var util = require('util');

function VerboseReporter(logger) {
function VerboseReporter(logger, config) {

/*
* Known events:
Expand Down Expand Up @@ -104,7 +104,7 @@ function VerboseReporter(logger) {
var browser = _browsers[i];
var log = logger.create(browser.name);
browser.log.forEach(function(entry) {
log[entry.level](entry.message);
(log[entry.level] || log.info).call(call, entry.message);
});
browser.log = [];
}
Expand Down Expand Up @@ -136,7 +136,13 @@ function VerboseReporter(logger) {
};

this.onBrowserLog = function(browser, message, level) {
forBrowser(browser).log.push({level: level, message: message});
if (level == 'log') level = 'info';
if (config.immediateLogs) {
var log = logger.create(browser.name);
(log[level] || log.info).call(log, message);
} else {
forBrowser(browser).log.push({level: level, message: message});
}
};

this.onBrowserError = function(browser, error) {
Expand Down Expand Up @@ -204,7 +210,8 @@ function VerboseReporter(logger) {
/* MODULE DECLARATION */
/* ========================================================================== */

VerboseReporter.$inject = ['logger'];
VerboseReporter.$inject = ['logger', 'config.verboseReporter'];

module.exports = {
'reporter:verbose': ['type', VerboseReporter]
};

0 comments on commit a97f486

Please sign in to comment.