Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log tweaks: Include environment information in log messages, use syslog logging levels. #523

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

adunkman
Copy link
Contributor

@adunkman adunkman commented Nov 9, 2020

As a followup to our audit logging discussions on Friday:

  • Include the environment in log messages. This will help filter messages in Kibana to only the environment we’re interested in (stg, dev, mig, irs, etc).

    • I also included the environment’s color configuration in the logs as well. That seems like it will be very helpful for metrics (ensuring requests switch colors when an environment switches colors, especially considering DNS propagation may be required).
  • Use syslog logging levels. This configures Winston to use syslog levels as specified in RFC5424:

    { 
      emerg: 0, 
      alert: 1, 
      crit: 2, 
      error: 3, 
      warning: 4, 
      notice: 5, 
      info: 6, 
      debug: 7
    }

    As per discussion, we’d like to continue to configure LOG_LEVEL to info, but would like to introduce using notice for logging messages which are required for auditing purposes.

@adunkman adunkman self-assigned this Nov 9, 2020
Copy link
Collaborator

@mmarcotte mmarcotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dancing

@mmarcotte mmarcotte merged commit 131bc68 into staging Nov 10, 2020
@adunkman adunkman deleted the log-tweaks branch November 10, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants