Estimated tax payments #586

ctSkennerton · 2021-09-26T03:40:19Z

Here is my initial pass at having a page for payments and implementing estimated taxes for form 1040 line 26.

- fix router - remove question

* Bump serde_json from 1.0.67 to 1.0.68 in /src-tauri (#567) Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.67 to 1.0.68. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.67...v1.0.68) --- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump typescript from 4.4.2 to 4.4.3 (#568) Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.4.2 to 4.4.3. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.4.2...v4.4.3) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @testing-library/react from 12.0.0 to 12.1.0 (#569) Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 12.0.0 to 12.1.0. - [Release notes](https://github.com/testing-library/react-testing-library/releases) - [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md) - [Commits](testing-library/react-testing-library@v12.0.0...v12.1.0) --- updated-dependencies: - dependency-name: "@testing-library/react" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @typescript-eslint/parser from 4.31.0 to 4.31.2 (#570) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.31.0 to 4.31.2. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.31.2/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump ajv from 8.6.2 to 8.6.3 (#571) Bumps [ajv](https://github.com/ajv-validator/ajv) from 8.6.2 to 8.6.3. - [Release notes](https://github.com/ajv-validator/ajv/releases) - [Commits](ajv-validator/ajv@v8.6.2...v8.6.3) --- updated-dependencies: - dependency-name: ajv dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump eslint-plugin-react from 7.25.1 to 7.26.0 (#572) Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.25.1 to 7.26.0. - [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases) - [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.25.1...v7.26.0) --- updated-dependencies: - dependency-name: eslint-plugin-react dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @types/react-router-dom from 5.1.8 to 5.1.9 (#574) Bumps [@types/react-router-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-router-dom) from 5.1.8 to 5.1.9. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-router-dom) --- updated-dependencies: - dependency-name: "@types/react-router-dom" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump prettier from 2.4.0 to 2.4.1 (#575) Bumps [prettier](https://github.com/prettier/prettier) from 2.4.0 to 2.4.1. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@2.4.0...2.4.1) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @craco/craco from 6.2.0 to 6.3.0 (#576) Bumps [@craco/craco](https://github.com/gsoft-inc/craco) from 6.2.0 to 6.3.0. - [Release notes](https://github.com/gsoft-inc/craco/releases) - [Commits](dilanx/craco@v6.2.0...v6.3.0) --- updated-dependencies: - dependency-name: "@craco/craco" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @types/react from 17.0.20 to 17.0.22 (#577) Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 17.0.20 to 17.0.22. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @typescript-eslint/eslint-plugin from 4.31.0 to 4.31.2 (#573) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.31.0 to 4.31.2. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.31.2/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @types/jest from 27.0.1 to 27.0.2 (#578) Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 27.0.1 to 27.0.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) --- updated-dependencies: - dependency-name: "@types/jest" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump react-hook-form from 7.15.2 to 7.15.4 (#580) Bumps [react-hook-form](https://github.com/react-hook-form/react-hook-form) from 7.15.2 to 7.15.4. - [Release notes](https://github.com/react-hook-form/react-hook-form/releases) - [Changelog](https://github.com/react-hook-form/react-hook-form/blob/master/CHANGELOG.md) - [Commits](react-hook-form/react-hook-form@v7.15.2...v7.15.4) --- updated-dependencies: - dependency-name: react-hook-form dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @types/node from 16.9.1 to 16.9.4 (#582) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 16.9.1 to 16.9.4. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @types/lodash from 4.14.172 to 4.14.173 (#581) Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.14.172 to 4.14.173. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash) --- updated-dependencies: - dependency-name: "@types/lodash" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

zakpatterson · 2021-09-27T05:09:26Z

Hey I saw this oddly was passing the linter action but failing when trying to deploy, due to two linter warnings. So I fixed the npm run lint command to disallow all warnings and cleaned those two up.

zakpatterson · 2021-09-27T05:11:40Z

I'm going to start gently nudging people to set up signed commits. I think it's a good step to take for code security:

#465

No problem on this PR, but at some point in the near future we'll start requiring it.

ctSkennerton · 2021-09-27T05:36:55Z

Thank you @zakpatterson! I added in a gpg key so my future commits should be properly verified.

netlify · 2021-09-28T03:47:47Z

A reviewer left a comment:

Save button doesn't work correctly when editing

Browser metadata

Path:      /payments/estimatedtaxes
Browser:   Chrome 93.0.4577.82 on Windows 10
Viewport:  1536 x 754 @1.25x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

thegrims · 2021-09-28T03:53:44Z

I think it might be good to start off estimated taxes with a question prompt of

did you already make payments towards your 2020 taxes this year or last year

or similar, to avoid confusion of what this field is asking for

codecov-commenter · 2021-09-28T03:57:40Z

Codecov Report

❗ No coverage uploaded for pull request base (master@5da2d4c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #586   +/-   ##
=========================================
  Coverage          ?   62.98%           
=========================================
  Files             ?      108           
  Lines             ?     3644           
  Branches          ?      552           
=========================================
  Hits              ?     2295           
  Misses            ?     1334           
  Partials          ?       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5da2d4c...30b8a07. Read the comment docs.

…xes into estimated-tax-payments

People may make several payments and wish to add them in separately. Adding a label field so that they can remember what each of them is.

ctSkennerton · 2021-10-04T04:13:56Z

I've updated the code to fix the issue with saving and also added in a label field in case a user has multiple payments and wants to provide a note for what each one is. I think the CI is running into the same issue as documented in #588, which is causing it to fail.

zakpatterson · 2021-10-04T06:20:21Z

I've updated the code to fix the issue with saving and also added in a label field in case a user has multiple payments and wants to provide a note for what each one is. I think the CI is running into the same issue as documented in #588, which is causing it to fail.

Agree. Reran twice and it passed.

zakpatterson · 2021-10-04T10:46:11Z

Looks good, not going to hold this up for testing given #588.

ctSkennerton and others added 7 commits September 25, 2021 17:10

Estimated tax as a question.

ee0f693

estimated tax as a page

d68307d

Fix bugs with estimated taxes as a page.

45ed489

- fix router - remove question

add in actions to validator

e984d03

lint

04351f7

Fix eslint to fail on warnings too

f171fc8

Fix two linter warnings

5fe20e4

Merge remote-tracking branch 'origin/master' into estimated-tax-payments

b95346b

ctSkennerton added 5 commits October 3, 2021 20:34

fix typo preventing editing of estimated tax payments

266b546

add text explaining estimated taxes

139eea8

Merge branch 'estimated-tax-payments' of github.com:ctSkennerton/UsTa…

4a645ad

…xes into estimated-tax-payments

Add in a label property to estimated taxes.

cae0eb6

People may make several payments and wish to add them in separately. Adding a label field so that they can remember what each of them is.

change the arbitary signature for estimated taxes to include label

30b8a07

thegrims approved these changes Oct 4, 2021

View reviewed changes

zakpatterson merged commit d19f5e0 into ustaxes:master Oct 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Estimated tax payments #586

Estimated tax payments #586

ctSkennerton commented Sep 26, 2021

zakpatterson commented Sep 27, 2021

zakpatterson commented Sep 27, 2021

ctSkennerton commented Sep 27, 2021 •

edited

Loading

netlify bot commented Sep 28, 2021

thegrims commented Sep 28, 2021

codecov-commenter commented Sep 28, 2021 •

edited

Loading

ctSkennerton commented Oct 4, 2021

zakpatterson commented Oct 4, 2021

zakpatterson commented Oct 4, 2021

Estimated tax payments #586

Estimated tax payments #586

Conversation

ctSkennerton commented Sep 26, 2021

zakpatterson commented Sep 27, 2021

zakpatterson commented Sep 27, 2021

ctSkennerton commented Sep 27, 2021 • edited Loading

netlify bot commented Sep 28, 2021

thegrims commented Sep 28, 2021

codecov-commenter commented Sep 28, 2021 • edited Loading

Codecov Report

ctSkennerton commented Oct 4, 2021

zakpatterson commented Oct 4, 2021

zakpatterson commented Oct 4, 2021

ctSkennerton commented Sep 27, 2021 •

edited

Loading

codecov-commenter commented Sep 28, 2021 •

edited

Loading