Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run setup script with ts-node #659

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

zakpatterson
Copy link
Collaborator

@zakpatterson zakpatterson commented Oct 19, 2021

Setup script compiles our runtime data schema definitions. This just moves it into a script folder and runs it as typescript code.

What kind of change does this PR introduce? (delete not applicable)

  • Refactor
  • Build-related changes

@zakpatterson zakpatterson changed the title Refactor setup js ts Run setup script with ts-node Oct 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2021

Codecov Report

Merging #659 (c323b29) into master (9bcefa2) will decrease coverage by 0.07%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
- Coverage   64.20%   64.13%   -0.08%     
==========================================
  Files         108      112       +4     
  Lines        3716     3739      +23     
  Branches      573      578       +5     
==========================================
+ Hits         2386     2398      +12     
- Misses       1315     1326      +11     
  Partials       15       15              
Impacted Files Coverage Δ
src/components/SaveToFile.tsx 0.00% <0.00%> (ø)
src/components/UserSettings.tsx 0.00% <0.00%> (ø)
src/redux/fs/Actions.ts 0.00% <0.00%> (ø)
src/redux/fs/Load.tsx 9.09% <9.09%> (ø)
src/redux/fs/index.ts 10.00% <10.00%> (ø)
src/redux/fs/FSReducer.ts 58.33% <58.33%> (ø)
src/redux/store.ts 69.23% <100.00%> (ø)
src/tests/common/Page.tsx 100.00% <100.00%> (ø)
src/irsForms/Schedule8812.ts 85.29% <0.00%> (-2.95%) ⬇️
src/irsForms/ScheduleEIC.ts 80.44% <0.00%> (+1.67%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bcefa2...c323b29. Read the comment docs.

@zakpatterson zakpatterson marked this pull request as draft October 19, 2021 12:13
Copy link
Collaborator

@thegrims thegrims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thegrims thegrims merged commit 1463e85 into ustaxes:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants