Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 9 swift 4 #65

Merged
5 commits merged into from
Feb 8, 2018
Merged

Xcode 9 swift 4 #65

5 commits merged into from
Feb 8, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 20, 2017

Resolves #64 Update to Xcode 9.1 and Swift 4.0.

  • Migrate to Swift 4
  • Update dependencies
  • Update CI to Xcode 9.1
  • Update SwiftLint to 0.24.0
  • Update .swift-version to 4.0
  • Ensure correct version of Ruby when running on Travis CI

@codecov-io
Copy link

codecov-io commented Nov 20, 2017

Codecov Report

Merging #65 into v3_0 will not change coverage.
The diff coverage is 91.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             v3_0      #65   +/-   ##
=======================================
  Coverage   59.67%   59.67%           
=======================================
  Files          44       44           
  Lines         548      548           
=======================================
  Hits          327      327           
  Misses        221      221
Impacted Files Coverage Δ
...urces/Configurations/CreditCardConfiguration.swift 96.66% <ø> (ø) ⬆️
Sources/Controls/ValidatorTextField-UIKit.swift 20.53% <0%> (ø) ⬆️
Sources/Conditions/AlphanumericCondition.swift 100% <100%> (ø) ⬆️
Sources/Conditions/RangeCondition.swift 100% <100%> (ø) ⬆️
Sources/Conditions/CreditCardCondition.swift 86.66% <100%> (ø) ⬆️
Sources/Conditions/NumericCondition.swift 100% <100%> (ø) ⬆️
Sources/Conditions/PasswordStrengthCondition.swift 90.47% <100%> (ø) ⬆️
Sources/Validators/CreditCardValidator.swift 100% <100%> (ø) ⬆️
Sources/Conditions/AlphabeticCondition.swift 100% <100%> (ø) ⬆️
Sources/Protocols/Condition.swift 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a9614...96acd67. Read the comment docs.

@ghost ghost merged commit 1d252a5 into v3_0 Feb 8, 2018
@ghost ghost deleted the xcode-9-swift-4 branch February 8, 2018 07:56
This was referenced Feb 8, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant