Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update CircleCI config. #1264

Merged
merged 8 commits into from
Sep 13, 2021
Merged

CI: Update CircleCI config. #1264

merged 8 commits into from
Sep 13, 2021

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Sep 8, 2021

Description

Resolves CircleCI build failures. Updates ruby in docker image to 2.6 → 2.7 in.circleci/config.yml. It's latest LTS release before 3.0 [efe4ab5]

Additional information

Note

  • We should add ffi to our Gemfile in the future if this pops again
  • Sometimes CircleCI will fail on npm run test:detached because it takes too long. In this case we should restart from failed until we look at potential options of speeding up CircleCI tasks

Other updates

  • Setting bundle path via config since --path flag will be deprecated soon [d88613a]
  • Consistent quotes in Gemfile [a1b1eed]
  • Upated Snyk and ran Snyk wizard [b2cceff] and [628390b]

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@mejiaj mejiaj marked this pull request as ready for review September 9, 2021 15:46
@mejiaj
Copy link
Contributor Author

mejiaj commented Sep 9, 2021

@thisisdano can you test this in ruby 2.6 (our current setup) and then again on 2.7? Just want to be sure this works on both. Locally I've switched to 2.7.

@thisisdano
Copy link
Member

Excellent. Thank you!

@thisisdano thisisdano merged commit 7856536 into main Sep 13, 2021
@thisisdano thisisdano deleted the jm-circleci-test branch September 13, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants