Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Site - Changelog: Update docs and add changelog for Icon list add size tokens [USWDS#5363] #2179

Merged
merged 7 commits into from
Aug 18, 2023
Merged

USWDS-Site - Changelog: Update docs and add changelog for Icon list add size tokens [USWDS#5363] #2179

merged 7 commits into from
Aug 18, 2023

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Jul 13, 2023 •
edited
Loading

Summary

Added changelog entries for uswds/uswds#5363

Related PR

Related to uswds/uswds#5363

Updated icon list styles to allow $theme-body-font-size to accept 2xs and 3xs size tokens.

Preview link

@amyleadem amyleadem mentioned this pull request Jul 13, 2023
Merged
@amyleadem amyleadem marked this pull request as ready for review July 14, 2023 16:21
@amyleadem amyleadem mentioned this pull request Jul 14, 2023
Merged
mahoneycm
mahoneycm approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@amyleadem amyleadem changed the base branch from main to release-3.5.1 July 21, 2023 19:25
@amyleadem amyleadem requested review from thisisdano and removed request for thisisdano August 2, 2023 18:59
@mejiaj mejiaj mentioned this pull request Aug 7, 2023
Closed
@mejiaj mejiaj changed the title USWDS-Site: Update docs and add changelog for #5363 USWDS-Site - Changelog: Update docs and add changelog for Icon list add size tokens [USWDS/USWDS#5363] Aug 8, 2023
@mejiaj mejiaj added Is: New Guidance A feature request for new guidance Affects: Guidance Relates to guidance Affects: Settings Relates to project settings labels Aug 8, 2023
@mejiaj mejiaj changed the title USWDS-Site - Changelog: Update docs and add changelog for Icon list add size tokens [USWDS/USWDS#5363] USWDS-Site - Changelog: Update docs and add changelog for Icon list add size tokens [USWDS#5363] Aug 8, 2023
@mejiaj mejiaj deleted the branch release-3.6.0 August 11, 2023 20:52
@mejiaj mejiaj closed this Aug 11, 2023
@mejiaj mejiaj mentioned this pull request Aug 11, 2023
Merged
@amyleadem amyleadem reopened this Aug 11, 2023
@amyleadem amyleadem changed the base branch from release-3.5.1 to release-3.6.0 August 11, 2023 21:13
@thisisdano thisisdano merged commit 30b3bc9 into release-3.6.0 Aug 18, 2023
1 check failed
@thisisdano thisisdano deleted the al-changelog-5363 branch August 18, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejiaj mejiaj mejiaj approved these changes

@thisisdano thisisdano thisisdano approved these changes

@mahoneycm mahoneycm mahoneycm approved these changes

Assignees
No one assigned
Labels
Affects: Guidance Relates to guidance Affects: Settings Relates to project settings Is: New Guidance A feature request for new guidance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amyleadem @mejiaj @thisisdano @mahoneycm