-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update section on browser support. #390
Conversation
This states / should state that the standards should support IE9 and up until a major release, and then will only support browsers above 2% usage on analytics.gov. This could potentially be worded in a way where it would not need to be updated in the future, such as after a major release or after browser support changes on analytics.gov. If that's better, we can rewrite it as such. Fixes uswds/uswds#2071
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good overall, though there are a few typos in the bullet points that ought to be fixed, if you decide to keep them... I also made some comments/suggestions that you can address or ignore at will!
pages/getting-started/developers.md
Outdated
@@ -211,7 +211,12 @@ NOTE: If you plan on upgrading to newer versions of the Standards in the future, | |||
|
|||
## Notes on accessibility | |||
|
|||
We’ve designed the Standards to support older and newer browsers through progressive enhancement, and they officially support Internet Explorer 9 and up, along with the latest versions of Chrome, Firefox, and Safari. Internet Explorer 8 and below generally see very low usage, and most agency websites should be able to safely begin support at Internet Explorer 9. | |||
- Originally the Standards were desiged to support Internet Explorer 9 and up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo, desiged
-> designed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Er also, there should be a period at the end of this sentence I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add a comma after Originally
pages/getting-started/developers.md
Outdated
@@ -211,7 +211,12 @@ NOTE: If you plan on upgrading to newer versions of the Standards in the future, | |||
|
|||
## Notes on accessibility | |||
|
|||
We’ve designed the Standards to support older and newer browsers through progressive enhancement, and they officially support Internet Explorer 9 and up, along with the latest versions of Chrome, Firefox, and Safari. Internet Explorer 8 and below generally see very low usage, and most agency websites should be able to safely begin support at Internet Explorer 9. | |||
- Originally the Standards were desiged to support Internet Explorer 9 and up | |||
- Now we're going to support any browser above 2% usage as defined on analytics.gov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Period at the end of this sentence. Also, should we hyperlink analytics.gov to the website? Or specifically hyperlink it to whatever part of analytics.gov shows the different browser percentages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure there is a hyperlink to just that section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL should be analytics.usa.gov
pages/getting-started/developers.md
Outdated
- Originally the Standards were desiged to support Internet Explorer 9 and up | ||
- Now we're going to support any browser above 2% usage as defined on analytics.gov | ||
- This currently means we support only Internet Explorer 11 and up. | ||
- There will be no breaking changes in older browsers until a major release, ie 2.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ie" should be "i.e."'... and yeah, we might want to file an issue to remind us to remove this once we actually release 2.0... Hmmm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to state we still support the: latest versions of Chrome, Firefox, and Safari ?
And the last sentence, should start: However, ...
pages/getting-started/developers.md
Outdated
- This currently means we support only Internet Explorer 11 and up. | ||
- There will be no breaking changes in older browsers until a major release, ie 2.0. | ||
|
||
We’ve designed the Standards to support older and newer browsers through progressive enhancement. The Standards will officially support any browser **above 2% usage** as defined on [analytics.usa.gov](https://analytics.usa.gov/). This currently means the Standards supports the newest versions of Chrome, Firefox, Safari and Internet Explorer 11 and up. Due to the Standards originally browser support, the Standards will support Internet Explorer 9 and up until the next major release, `2.0`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Er wait, doesn't this just re-state the above bullet points? Should we just remove the bullet points and keep this instead?
Also, I'm not sure if the "accessibility" section is the best place for this--we've already had a number of people ask about browser support in our Slack channel, which indicates that the existing blurb about IE9 might be too difficult to find. I wonder if we should add a new section called "browser support" or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops I meant to take the bullet points out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd agree, we might want to create a new section.
As it's often missed in the accessibility section and people are asking for it a lot
pages/getting-started/developers.md
Outdated
@@ -211,7 +211,12 @@ NOTE: If you plan on upgrading to newer versions of the Standards in the future, | |||
|
|||
## Notes on accessibility | |||
|
|||
We’ve designed the Standards to support older and newer browsers through progressive enhancement, and they officially support Internet Explorer 9 and up, along with the latest versions of Chrome, Firefox, and Safari. Internet Explorer 8 and below generally see very low usage, and most agency websites should be able to safely begin support at Internet Explorer 9. | |||
- Originally the Standards were desiged to support Internet Explorer 9 and up | |||
- Now we're going to support any browser above 2% usage as defined on analytics.gov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about....Now, we'll support any browser with more than a 2% usage rate, as defined on analytics.usa.gov.
pages/getting-started/developers.md
Outdated
- This currently means we support only Internet Explorer 11 and up. | ||
- There will be no breaking changes in older browsers until a major release, ie 2.0. | ||
|
||
We’ve designed the Standards to support older and newer browsers through progressive enhancement. The Standards will officially support any browser **above 2% usage** as defined on [analytics.usa.gov](https://analytics.usa.gov/). This currently means the Standards supports the newest versions of Chrome, Firefox, Safari and Internet Explorer 11 and up. Due to the Standards originally browser support, the Standards will support Internet Explorer 9 and up until the next major release, `2.0`. | ||
|
||
The Standards also meet the [WCAG 2.0 AA accessibility guidelines](https://www.w3.org/TR/WCAG20/) and are compliant with [Section 508 of the Rehabilitation Act](http://www.section508.gov/). We’re happy to answer questions about accessibility — email us for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add a link to the Google group (uswebdesignstandards@gsa.gov) to the 'email us for more information.' clause.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some comments in the individual sentences. Thanks!
This states / should state that the standards should support IE9 and up until a major release, and then will only support browsers above 2% usage on analytics.gov.
This could potentially be worded in a way where it would not need to be updated in the future, such as after a major release or after browser support changes on analytics.gov. If that's better, we can rewrite it as such.
Fixes uswds/uswds#2071