Add card component documentation #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add raised, media, and flag card variants. Add singular and plural Card redirects.
- Add usa-card size in ui-components/overview.md - Add package requirements in Card documentation page
Create Card settings section in `documentation/settings/#components`.
- Remove duplicate entries - Fix setting type on button family and border radius (they were flipped)
|
53 tasks
thisisdano
moved this from Fed final review
to QA and initial review
in USWDS Sprint Board
5 tasks
thisisdano
changed the title
This was
linked to
issues
Apr 13, 2020
- Update guidance - Add `$theme-card-flag-min-width` to settings page - Fix Card header variable to "header" instead of "ui" - Update new card component package size (now without layout)
thisisdano
moved this from QA and initial review
to Fed final review
in USWDS Sprint Board
thisisdano
approved these changes
May 8, 2020
|
Once uswds/uswds#3430 is merged, we just need to update to the |
|
OK, ready for final review. |
|
LGTM, do we need anyone else to review? @thisisdano |
|
I think at this point we're good to merge |
This was referenced May 8, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview →
Description
Add card component documentation.
Additional information
Include any of the following (as necessary):
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.