Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add combo box implementation guidance #978

Closed
wants to merge 1 commit into from

Conversation

thisisdano
Copy link
Member

@thisisdano thisisdano commented Jun 16, 2020

Added:
Add a default value or a placeholder with data attributes. Add a default value to the combo box by adding a data-default-value attribute to the div.usa-combo-box element using the id of the option you want to be the default value as the attribute's value. Add a placeholder to the combo box by adding a data-placeholder attribute to the div.usa-combo-box element. The placeholder value can be any string.

@thisisdano thisisdano requested a review from wbyoko June 16, 2020 21:42
@thisisdano
Copy link
Member Author

@wbyoko Anything I'm missing here, or any changes you would make?

@thisisdano
Copy link
Member Author

closed in favor of #982

@thisisdano thisisdano closed this Jun 17, 2020
@thisisdano thisisdano deleted the dw-update-combobox-guidance branch June 17, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant