Combo box updates for 2.7.1 #3512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for identifying the base select element
* it is enhanced to add the class and is not required markup
* specs * styles * manage pristine selection state
…mouseover-selection # Conflicts: # src/js/components/combo-box.js
…disabled-combo-box # Conflicts: # src/js/components/combo-box.js
…box-data-attributes
…combobox-subsequent-selection # Conflicts: # src/js/components/combo-box.js
toggle list update tabindex
…-combobox-subsequent-selection # Conflicts: # spec/unit/combo-box/combo-box-change-event.spec.js # spec/unit/combo-box/combo-box.spec.js # src/js/components/combo-box.js
…-combobox-subsequent-selection # Conflicts: # spec/unit/combo-box/combo-box.spec.js
…combobox-subsequent-selection # Conflicts: # spec/unit/combo-box/combo-box.spec.js # src/js/components/combo-box.js
* reset selection on tab
USWDS-3474 Disabled Combo Box Enhancement
…ta-attributes # Conflicts: # spec/unit/combo-box/combo-box.spec.js
USWDS-3477 USWDS-3482 Combo Box Data Attributes
…ver-selection # Conflicts: # spec/unit/combo-box/combo-box.spec.js
USWDS-3490 Combo Box Mouseover Selection
…ox-subsequent-selection # Conflicts: # spec/unit/combo-box/combo-box.spec.js
needed for subsequent selection
fire events on clear highlight selected item on open make sure shift+tab does nothing
after adding new buttons for toggle and clear. we need new functions to support disable and enable.
remove hover/active styles
…combobox-subsequent-selection
…ox-subsequent-selection
…t-selection USWDS-3479 Combo Box Subsequent Selection
wbyoko
approved these changes
Jun 16, 2020
There was a problem hiding this comment.
data-default-value and data-placeholder should get guidance updates. I'll work on that.
@thisisdano @Ben-Judy-Flexion In this situation of dragging should we disable the focus outline?
|
Yeah, I think it could be disabled for the drag/scroll. Looks like I'm going to get to the 2.7.1 release tomorrow, so if you have PR ready by then, I can include it. |
…n-list USWDS Disable focus outline on drag
|
Added a combo box implementation guidance PR here: uswds/uswds-site#978 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview →
Show proper focus in combo box. Hover and keyboard events transfer focus to individual options, and now the styling reflects that. (#3493)
Disabled combo boxes remain disabled after enhancement. The
disabledattribute now correctly results in a disabled combo box. (#3484)Use data attributes to set combo box placeholder and default.
The combo box now selects the first item of the combo box when no placeholder is present and no placeholder by default.We now use data attributes to set the default value (data-default-value)and placeholder (data-placeholder). (#3486)Improved combo box interactions. Allows list toggling with the toggle button, and adds a "clear input" button to start a subsequent combo box interaction. Makes a number of additional improvement to how the combo box handles changes and new selections. (#3505)
This PR follows up on the following combo box improvements:
Combo box now triggers a change event on
inputandselectchange. Now we fire proper change events on the<select>. (#3487)We fixed the punctuation on the default combo box. Now there's no more colon, consistent with other input guidance. (#3473)
The combo box scrollbar works. Now you can scroll a combo box! (#3483)